Closed
Bug 1822985
Opened 2 years ago
Closed 2 years ago
Convert toolkit/components/antitracking to an ES module
Categories
(Core :: Privacy: Anti-Tracking, task, P3)
Core
Privacy: Anti-Tracking
Tracking
()
RESOLVED
FIXED
113 Branch
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: standard8, Assigned: omegajudith, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [esmification-timeline][lang=js])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Here's what to do:
- Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
- If you need help setting up, ask in #introduction on Matrix
- Using the ESMification walkthrough as a guide:
- Run
./mach esmify --convert path/to/files
- Examine the output for any errors from ESLint and fix them.
- Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
- Next convert the imports -
./mach esmify --import . --prefix path/to/files
- Again, check for any errors and fix them.
- Run a build to check it passes.
- Also run
./mach eslint --fix path/to/files
and check there are no raised failures - Commit the changes with a commit message such as "Bug nnnnnn - Convert consumers of path/to/files to import ES modules directly. r?Standard8"
- Run
- Use
moz-phab submit
to submit the patches for review.
I'm going to mentor Judith on this bug, as they have been looking for something to take on.
Assignee | ||
Comment 1•2 years ago
|
||
Thanks, @standard8. I am excited to do this
Assignee | ||
Comment 2•2 years ago
|
||
Updated•2 years ago
|
Attachment #9323672 -
Attachment description: Bug 1822985 - Convert path/to/files to ES modules. r?Standard8 → Bug 1822985 - Convert toolkit/components/antitracking to ES modules. r?Standard8
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f1a749ebd48
Convert toolkit/components/antitracking to ES modules. r=Standard8
Comment 4•2 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•