Closed Bug 1822985 Opened 2 years ago Closed 2 years ago

Convert toolkit/components/antitracking to an ES module

Categories

(Core :: Privacy: Anti-Tracking, task, P3)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: standard8, Assigned: omegajudith, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [esmification-timeline][lang=js])

Attachments

(1 file)

Here's what to do:

  • Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • Using the ESMification walkthrough as a guide:
    1. Run ./mach esmify --convert path/to/files
    2. Examine the output for any errors from ESLint and fix them.
    3. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
    4. Next convert the imports - ./mach esmify --import . --prefix path/to/files
    5. Again, check for any errors and fix them.
    6. Run a build to check it passes.
    7. Also run ./mach eslint --fix path/to/files and check there are no raised failures
    8. Commit the changes with a commit message such as "Bug nnnnnn - Convert consumers of path/to/files to import ES modules directly. r?Standard8"
  • Use moz-phab submit to submit the patches for review.

I'm going to mentor Judith on this bug, as they have been looking for something to take on.

Thanks, @standard8. I am excited to do this

Attachment #9323672 - Attachment description: Bug 1822985 - Convert path/to/files to ES modules. r?Standard8 → Bug 1822985 - Convert toolkit/components/antitracking to ES modules. r?Standard8
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f1a749ebd48 Convert toolkit/components/antitracking to ES modules. r=Standard8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: