The weather suggestion fetch should be delayed on wake like it is when coming online
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In bug 1822918 we added a small delay before fetching after the computer comes online so that multiple notifications don't cause multiple fetches. We should probably do that for wake too because it's conceivable that online notifications might happen soon after the wake notification. Sync also does this.
|
Assignee | |
Comment 1•2 years ago
|
||
This adds a delay after wake just like the delay after online notifications.
It's conceivable that online notifications might happen soon after the wake
notification. Sync also does this.
I renamed cameOnlineDelayMs to fetchDelayAfterComingOnlineMs. It's longer
but I think it's clearer. I don't think we need a separate delay ms for wake; we
can just use the same one that we use for online.
I also added a test for a wake notification followed by online notifications.
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
|
||
Comment 4•2 years ago
|
||
(In reply to Pulsebot from comment #2)
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e86d4f075920
Fetch the weather suggestion on a slight delay after wake. r=daisuke
== Change summary for alert #37718 (as of Tue, 21 Mar 2023 22:39:47 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 3% | displaylist_mutate | macosx1015-64-shippable-qr | e10s fission stylo webrender | 1,829.51 -> 1,774.13 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37718
Description
•