Closed
Bug 1823399
Opened 2 years ago
Closed 2 years ago
Accept startColumn argument for Debugger.Object.createSource
Categories
(DevTools :: Debugger, task)
DevTools
Debugger
Tracking
(firefox113 fixed)
RESOLVED
FIXED
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(2 files)
The function takes a startLine parameter, but not a startColumn one, see https://searchfox.org/mozilla-central/rev/3c3ad00ab7f587e2c75e8cebb89badc4e946b10e/js/src/debugger/Object.cpp#1224-1231
|
Assignee | |
Comment 1•2 years ago
|
||
Depends on D172979
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D173023
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f931921c97f2
Add startColumn option to Debugger.Object.createSource. r=tcampbell.
|
||
Comment 4•2 years ago
|
||
Backed out 3 changesets (Bug 1823335, Bug 1815937, Bug 1823399) for devtools failures on browser_dbg-features-breakable-positions.js
Backout link <--> dt12
Failure Log
Also dt3 Failure Log
Flags: needinfo?(nchevobbe)
|
|
Assignee | |
Comment 5•2 years ago
|
||
looks like this need one of the patch I didn't include in my push
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d79f18bc240
Add startColumn option to Debugger.Object.createSource. r=tcampbell.
https://hg.mozilla.org/integration/autoland/rev/6691c86f4443
[devtools] Pass startColumn to createSource. r=devtools-reviewers,jdescottes.
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0d79f18bc240
https://hg.mozilla.org/mozilla-central/rev/6691c86f4443
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•