Closed Bug 1823643 Opened 2 years ago Closed 2 years ago

In ProviderQuickSuggest::blockResult, check result.payload.isBlockable instead of re-determining whether blocking is enabled

Categories

(Firefox :: Address Bar, task)

Product:
Firefox
Component:
Address Bar
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [snt-urlbar-result-menu])

Attachments

(1 file)

Bug 1823643 - In ProviderQuickSuggest::blockResult, check result.payload.isBlockable instead of re-determining whether blocking is enabled. r=adw
(deleted), text/x-phabricator-request
Details

Following up from bug 1823608. It doesn't seem to make sense to re-determine whether blocking is enabled when that same information is already available via result.payload.isBlockable.

Summary: Check result.payload.isBlockable in ProviderQuickSuggest::blockResult instead of re-determining whether blocking is enabled → In ProviderQuickSuggest::blockResult, check result.payload.isBlockable instead of re-determining whether blocking is enabled
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4abc4e55049e In ProviderQuickSuggest::blockResult, check result.payload.isBlockable instead of re-determining whether blocking is enabled. r=adw

https://hg.mozilla.org/mozilla-central/rev/4abc4e55049e

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: