Open Bug 1824273 Opened 2 years ago Updated 1 year ago

Intermittent browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | single tracking bug

Categories

(Firefox :: Firefox View, defect, P3)

defect

Tracking

()

Tracking Status
firefox-esr102 --- unaffected
firefox111 --- unaffected
firefox112 --- unaffected
firefox113 --- affected
firefox114 --- affected

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(4 keywords, Whiteboard: [stockwell disabled] [fidefe-firefox-view] )

Attachments

(1 file)

Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=410023503&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/RpTtbPSZQdyhWqZvOYf-MA/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/RpTtbPSZQdyhWqZvOYf-MA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


[task 2023-03-24T01:30:42.991Z] 01:30:42     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | Second item in Tab Pickup list is The Times - true == true - 
[task 2023-03-24T01:30:42.992Z] 01:30:42     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | Third item in Tab Pickup list is Sandboxes - Sinon.JS - true == true - 
[task 2023-03-24T01:30:42.993Z] 01:30:42     INFO - Stubbed SyncedTabs.getRecentTabs returning a promise that resolves to 3 tabs
[task 2023-03-24T01:30:42.993Z] 01:30:42     INFO - 
[task 2023-03-24T01:30:42.994Z] 01:30:42     INFO - Console message: 1679621442206	FirefoxView.TabsSetup	DEBUG	Handling UIState update
[task 2023-03-24T01:30:42.996Z] 01:30:42     INFO - Console message: 1679621442214	FirefoxView.TabsSetup	DEBUG	onSignedInChange, fxaSignedIn:: true
[task 2023-03-24T01:30:42.997Z] 01:30:42     INFO - Console message: 1679621442221	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, conditions not met to exit state: : synced-tabs-loaded
[task 2023-03-24T01:30:42.998Z] 01:30:42     INFO - Console message: 1679621442223	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, will notify update?:: true
[task 2023-03-24T01:30:42.999Z] 01:30:42     INFO - Console message: 1679621442275	FirefoxView.TabsSetup	DEBUG	refreshDevices, mobileDeviceConnected: true, : secondaryDeviceConnected: true
[task 2023-03-24T01:30:43.000Z] 01:30:43     INFO - A child node has been added or removed:SPAN
[task 2023-03-24T01:30:43.001Z] 01:30:43     INFO - A child node has been added or removed:SPAN
[task 2023-03-24T01:30:43.002Z] 01:30:43     INFO - A child node has been added or removed:SPAN
[task 2023-03-24T01:30:43.004Z] 01:30:43     INFO - Console message: 1679621442276	FirefoxView.TabsSetup	DEBUG	refreshDevices: no device state change
[task 2023-03-24T01:30:43.005Z] 01:30:43     INFO - Console message: 1679621442298	FirefoxView.TabsSetup	DEBUG	onSignedInChange, tabSyncNeeded:: false
[task 2023-03-24T01:30:43.005Z] 01:30:43     INFO - Buffered messages finished
[task 2023-03-24T01:30:43.010Z] 01:30:43     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | The synced tabs list was not mutated - false == true - {"filename":"chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js","name":"test_tabs_dont_update_unnecessarily/<","sourceId":1065,"lineNumber":792,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"resource://testing-common/FirefoxViewTestUtils.sys.mjs","name":"withFirefoxView","sourceId":579,"lineNumber":90,"columnNumber":22,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js","name":"test_tabs_dont_update_unnecessarily","sourceId":1065,"lineNumber":732,"columnNumber":9,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"handleTask","sourceId":529,"lineNumber":1039,"columnNumber":26,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"_runTaskBasedTest","sourceId":529,"lineNumber":1111,"columnNumber":18,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"Tester_execTest","sourceId":529,"lineNumber":1253,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest/<","sourceId":529,"lineNumber":1022,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/tests/SimpleTest/SimpleTest.js","name":"SimpleTest.waitForFocus/<","sourceId":559,"lineNumber":1053,"columnNumber":13,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13\n","nativeSavedFrame":{}},"formattedStack":"nextTest/<@chrome://mochikit/content/browser-test.js:1022:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13\n","nativeSavedFrame":{}},"formattedStack":"async*Tester_execTest@chrome://mochikit/content/browser-test.js:1253:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1022:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1111:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1253:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1022:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13\n","nativeSavedFrame":{}},"formattedStack":"handleTask@chrome://mochikit/content/browser-test.js:1039:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1111:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1253:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1022:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13\n","nativeSavedFrame":{}},"formattedStack":"async*test_tabs_dont_update_unnecessarily@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js:732:9\nhandleTask@chrome://mochikit/content/browser-test.js:1039:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1111:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1253:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1022:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"async*withFirefoxView@resource://testing-common/FirefoxViewTestUtils.sys.mjs:90:22\nasync*test_tabs_dont_update_unnecessarily@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js:732:9\nhandleTask@chrome://mochikit/content/browser-test.js:1039:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1111:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1253:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1022:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"test_tabs_dont_update_unnecessarily/<@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js:792:12\nasync*withFirefoxView@resource://testing-common/FirefoxViewTestUtils.sys.mjs:90:22\nasync*test_tabs_dont_update_unnecessarily@chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js:732:9\nhandleTask@chrome://mochikit/content/browser-test.js:1039:26\n_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1111:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1253:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1022:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1053:13\n","nativeSavedFrame":{}}
[task 2023-03-24T01:30:43.011Z] 01:30:43     INFO - Stack trace:
[task 2023-03-24T01:30:43.011Z] 01:30:43     INFO - chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js:test_tabs_dont_update_unnecessarily/<:792
[task 2023-03-24T01:30:43.011Z] 01:30:43     INFO - resource://testing-common/FirefoxViewTestUtils.sys.mjs:withFirefoxView:90
[task 2023-03-24T01:30:43.011Z] 01:30:43     INFO - chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js:test_tabs_dont_update_unnecessarily:732
[task 2023-03-24T01:30:43.011Z] 01:30:43     INFO - chrome://mochikit/content/browser-test.js:handleTask:1039
[task 2023-03-24T01:30:43.011Z] 01:30:43     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1111
[task 2023-03-24T01:30:43.015Z] 01:30:43     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1253
[task 2023-03-24T01:30:43.015Z] 01:30:43     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1022
[task 2023-03-24T01:30:43.015Z] 01:30:43     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1053
[task 2023-03-24T01:30:43.160Z] 01:30:43     INFO - Console message: 1679621442817	FirefoxView.TabsSetup	DEBUG	updateViewVisibility for instance: 4944152, visibility: hidden
[task 2023-03-24T01:30:43.172Z] 01:30:43     INFO - Console message: 1679621442820	FirefoxView.TabsSetup	DEBUG	Resetting timestamp and tabs pending flags as there are no visible views
[task 2023-03-24T01:30:43.174Z] 01:30:43     INFO - Console message: 1679621442823	FirefoxView.TabsSetup	DEBUG	updateViewVisibility for instance: 4944152, visibility: unloaded
[task 2023-03-24T01:30:43.176Z] 01:30:43     INFO - Console message: 1679621442825	FirefoxView.TabsSetup	DEBUG	Resetting timestamp and tabs pending flags as there are no visible views
[task 2023-03-24T01:30:43.249Z] 01:30:43     INFO - Leaving test bound test_tabs_dont_update_unnecessarily
[task 2023-03-24T01:30:43.268Z] 01:30:43     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | in firefoxview/head.js, SyncedTabs._internal._createRecentTabsList is a function - 
[task 2023-03-24T01:30:43.409Z] 01:30:43     INFO - GECKO(12080) | MEMORY STAT | vsize 130560510MB | residentFast 1648MB
[task 2023-03-24T01:30:43.414Z] 01:30:43     INFO - TEST-OK | browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | took 28688ms
[task 2023-03-24T01:30:43.590Z] 01:30:43     INFO - checking window state
[task 2023-03-24T01:30:48.453Z] 01:30:48     INFO - GECKO(12080) | Completed ShutdownLeaks collections in process 12219
[task 2023-03-24T01:30:48.480Z] 01:30:48     INFO - GECKO(12080) | Completed ShutdownLeaks collections in process 12172
[task 2023-03-24T01:30:48.527Z] 01:30:48     INFO - GECKO(12080) | Completed ShutdownLeaks collections in process 12284
[task 2023-03-24T01:30:48.719Z] 01:30:48     INFO - GECKO(12080) | Completed ShutdownLeaks collections in process 12146
[task 2023-03-24T01:30:50.097Z] 01:30:50     INFO - GECKO(12080) | ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory
[task 2023-03-24T01:30:51.402Z] 01:30:51     INFO - GECKO(12080) | Completed ShutdownLeaks collections in process 12080
[task 2023-03-24T01:30:51.405Z] 01:30:51     INFO - TEST-START | Shutdown
[task 2023-03-24T01:30:51.406Z] 01:30:51     INFO - Browser Chrome Test Summary
[task 2023-03-24T01:30:51.410Z] 01:30:51     INFO - Passed:  654
[task 2023-03-24T01:30:51.411Z] 01:30:51     INFO - Failed:  1
[task 2023-03-24T01:30:51.412Z] 01:30:51     INFO - Todo:    0
[task 2023-03-24T01:30:51.413Z] 01:30:51     INFO - Mode:    e10s
[task 2023-03-24T01:30:51.414Z] 01:30:51     INFO - *** End BrowserChrome Test Results ***

:sfoster, since you are the author of the regressor, bug 1809661, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(sfoster)

Tier 1 failure here

Summary: Intermittent TV browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | single tracking bug → Intermittent browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js | single tracking bug

Set release status flags based on info from the regressing bug 1809661

Tier 1 failure here

This looks the same as bug 1794435. But I put a patch on that a day or 2 ago. Does this mean my patch from bug 1809661 undid the work I did in bug 1794435? Or might the patch from 1794435 not been applied when those failures have occurred?

Flags: needinfo?(sfoster) → needinfo?(nfay)

Hello, after taking a look at this bug and Bug 1794435 , the failure seems to be identical. I think it could be the case that after landing Bug 1809661 , something has changed or impacted the patch made in Bug 1794435 and caused the failure to reappear since the patch was already in autoland and it seemed to be working well until the landing of Bug 1809661 , which should exclude the fact that the patch wasn't applied.

Flags: needinfo?(nfay) → needinfo?(sfoster)

Thanks for confirming. Some of this code is likely going to get refactored if not outright re-designed as we migrate to more reusable components as part of our v2 work. So I'd like to just keep an eye on the frequency of failures for now. If it becomes necessary, we can just disable this particular test_tabs_dont_update_unnecessarily test without losing the rest of the coverage provided in that file.

Flags: needinfo?(sfoster)

I want to see if bug 1821094 fixes or changes the failure here, I don't think it makes sense to fiddle with the test until that work is done.

Depends on: 1821094

Set release status flags based on info from the regressing bug 1809661

There have been 50 total failures in the last 7 days.
There are:

  • 14 failures on linux1804-64-asan-qr opt
  • 24 failures on linux1804-64-qr debug and opt
  • 2 failures on linux1804-64-tsan-qr opt
  • 1 failure on macosx1015-64-qr debug
  • 1 failure on windows11-32-2009-qr debug
  • 1 failure on windows11-64-2009-asan-qr opt
  • 7 failures on windows11-64-2009-qr opt and debug

Recent failure log.

Sam, as the owner of this component, can you help us assign the bug to someone? Thank you.

Flags: needinfo?(sfoster)
Whiteboard: [stockwell needswork:owner]

I can take another look into this to see what is making failures so frequent.

Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Flags: needinfo?(sfoster)

Sam, any updates on this one? Should we disable the test until a fix is in place?

Flags: needinfo?(sfoster)

(In reply to Cosmin Sabou [:CosminS] from comment #20)

Sam, any updates on this one? Should we disable the test until a fix is in place?

That might be best yes, I'm not likely to get to this soon.

Flags: needinfo?(sfoster)
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/737067327542 Disable browser_tab_pickup_list.js for frequent failures until a fix in place. r=intermittent-reviewers,jmaher
Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Whiteboard: [stockwell disabled] → [stockwell disabled] [fidefe-firefox-view]
Assignee: sfoster → nobody
Status: ASSIGNED → NEW
Priority: P5 → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: