Improve GMP diagnostics when attempting to first load plugin
Categories
(Core :: Audio/Video: GMP, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We have a bunch of crashes on the GMPChild::RecvStartPlugin path. It would be good to break these out to understand why the process is failing to sanitize the plugin path.
|
Assignee | |
Comment 1•2 years ago
|
||
We are currently seeing crashes in GMPChild::RecvStartPlugin because we
fail to sanitize the plugin path in some way. This patch will make
nightly crash slightly sooner than before so that we can understand why
the sanitization is actually failing.
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
|
||
Comment 4•2 years ago
|
||
Nit: https://hg.mozilla.org/mozilla-central/rev/27a68283e532be19f1db26fcdb55d5a98b2f7be0#l1.136 should be GMP_DIAGNOSTIC_CRASH
|
||
Comment 5•2 years ago
|
||
(In reply to [:fabrice] Fabrice Desré from comment #4)
Nit: https://hg.mozilla.org/mozilla-central/rev/27a68283e532be19f1db26fcdb55d5a98b2f7be0#l1.136 should be GMP_DIAGNOSTIC_CRASH
You're right. Builds using "ac_add_options --as-milestone=release" in mozconfig fail because of this.
Description
•