Some canonicalization should still apply to query string
Categories
(Toolkit :: Safe Browsing, defect, P2)
Tracking
()
People
(Reporter: hectorz, Assigned: dimi)
References
(Regression)
Details
(Keywords: regression)
Hi, we're looking at some other URLs in our safe browsing list but not blocked in Fx, and I think there's a client side bug from the previous fix.
In https://developers.google.com/safe-browsing/v4/urls-hashing?hl=en#canonicalization, when talking about "Do not apply these path canonicalizations to the query parameters" I think it's only referring to the two slash related ones above the sentence, while the "percent-unescape" above and "percent-escape" below that part should still apply.
While the fix in https://hg.mozilla.org/mozilla-central/rev/2e19e69edfcb means the query string will be returned by GetKeyForURI
w/o going through any of that.
Reporter | ||
Comment 1•2 years ago
|
||
As an example, while both https://wiki.mozilla.org/index.php?title=MozillaWiki:Help&action=history and https://wiki.mozilla.org/index.php?title=MozillaWiki%3AHelp&action=history can reach the same page,
» let urlUtils = Cc["@mozilla.org/url-classifier/utils;1"].getService(Ci.nsIUrlClassifierUtils);
← <XPCWrappedNative_NoHelper ...>
» urlUtils.getKeyForURI(Services.io.newURI("https://wiki.mozilla.org/index.php?title=MozillaWiki:Help&action=history"))
← "wiki.mozilla.org/index.php?title=MozillaWiki:Help&action=history"
» urlUtils.getKeyForURI(Services.io.newURI("https://wiki.mozilla.org/index.php?title=MozillaWiki%3AHelp&action=history"))
← "wiki.mozilla.org/index.php?title=MozillaWiki%3AHelp&action=history"
Comment 2•2 years ago
|
||
Set release status flags based on info from the regressing bug 1676804
:dimi, since you are the author of the regressor, bug 1676804, could you take a look? Also, could you set the severity field?
For more information, please visit auto_nag documentation.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 3•2 years ago
|
||
Set release status flags based on info from the regressing bug 1676804
Updated•2 years ago
|
Updated•2 years ago
|
Description
•