Closed Bug 1825228 Opened 2 years ago Closed 1 year ago

Intermittent toolkit/mozapps/update/tests/browser/browser_aboutPrefs_<smth>.js | single tracking bug

Categories

(Toolkit :: Application Update, defect, P5)

Product:
Toolkit
Component:
Application Update
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox111 --- unaffected
firefox112 --- unaffected
firefox113 --- wontfix
firefox114 --- wontfix
firefox115 --- fixed
firefox116 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: robwu)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, test-verify-fail)

Attachments

(1 file)

Bug 1825228 - Correctly await l10n completion in update tests
(deleted), text/x-phabricator-request
Details

Filed by: ctuns [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=410628564&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ICv1lXB2RzGKhfWFDQ1iuQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ICv1lXB2RzGKhfWFDQ1iuQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

[task 2023-03-29T08:18:58.622Z] 08:18:58     INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js | The panel ID should equal internalError - "internalError" == "internalError" - 
[task 2023-03-29T08:18:58.629Z] 08:18:58     INFO - Buffered messages finished
[task 2023-03-29T08:18:58.629Z] 08:18:58     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js | The current update state should be "STATE_IDLE". Actual: "STATE_DOWNLOADING" - Got 2, expected 1
[task 2023-03-29T08:18:58.631Z] 08:18:58     INFO - Stack trace:
[task 2023-03-29T08:18:58.631Z] 08:18:58     INFO - chrome://mochikit/content/browser-test.js:test_is:1512
[task 2023-03-29T08:18:58.631Z] 08:18:58     INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutPrefsUpdateTest/processAboutPrefsStep/<:1008
[task 2023-03-29T08:18:58.632Z] 08:18:58     INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:processAboutPrefsStep:1146
[task 2023-03-29T08:18:58.632Z] 08:18:58     INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutPrefsUpdateTest/<:1221
[task 2023-03-29T08:18:58.633Z] 08:18:58     INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutPrefsUpdateTest:1223
[task 2023-03-29T08:18:58.634Z] 08:18:58     INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js:aboutPrefs_internalError:30
[task 2023-03-29T08:18:58.634Z] 08:18:58     INFO - chrome://mochikit/content/browser-test.js:handleTask:1039
[task 2023-03-29T08:18:58.635Z] 08:18:58     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1111
[task 2023-03-29T08:18:58.635Z] 08:18:58     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1253
[task 2023-03-29T08:18:58.636Z] 08:18:58     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1022
[task 2023-03-29T08:18:58.636Z] 08:18:58     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1053
[task 2023-03-29T08:18:58.637Z] 08:18:58     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-03-29T08:18:58.637Z] 08:18:58     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js | There should not be a downloading update - 
[task 2023-03-29T08:18:58.638Z] 08:18:58     INFO - Stack trace:
[task 2023-03-29T08:18:58.638Z] 08:18:58     INFO - chrome://mochikit/content/browser-test.js:test_ok:1484
[task 2023-03-29T08:18:58.639Z] 08:18:58     INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutPrefsUpdateTest/processAboutPrefsStep/<:1028
[task 2023-03-29T08:18:58.639Z] 08:18:58     INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:processAboutPrefsStep:1146
[task 2023-03-29T08:18:58.640Z] 08:18:58     INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutPrefsUpdateTest/<:1221
[task 2023-03-29T08:18:58.640Z] 08:18:58     INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutPrefsUpdateTest:1223
[task 2023-03-29T08:18:58.641Z] 08:18:58     INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js:aboutPrefs_internalError:30
[task 2023-03-29T08:18:58.642Z] 08:18:58     INFO - chrome://mochikit/content/browser-test.js:handleTask:1039
[task 2023-03-29T08:18:58.642Z] 08:18:58     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1111
[task 2023-03-29T08:18:58.642Z] 08:18:58     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1253
[task 2023-03-29T08:18:58.644Z] 08:18:58     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1022
[task 2023-03-29T08:18:58.645Z] 08:18:58     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1053
[task 2023-03-29T08:18:58.646Z] 08:18:58     INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js | There should not be a ready update - 
[task 2023-03-29T08:18:58.647Z] 08:18:58     INFO - Leaving test bound aboutPrefs_internalError
[task 2023-03-29T08:18:59.030Z] 08:18:59     INFO - GECKO(3722) | MEMORY STAT | vsize 130560308MB | residentFast 1320MB
[task 2023-03-29T08:18:59.033Z] 08:18:59     INFO - TEST-OK | toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js | took 5698ms

Set release status flags based on info from the regressing bug 1801379

:canadahonk, since you are the author of the regressor, bug 1801379, could you take a look?

For more information, please visit auto_nag documentation.

status-firefox111: --- → unaffected
status-firefox112: --- → unaffected
status-firefox113: --- → affected
status-firefox-esr102: --- → unaffected
Flags: needinfo?(oj)

Not sure myself. All Bug 1801379 did was migrate Sinon to ESM, afaict it couldn't cause an intermittent like this?

Flags: needinfo?(oj)

Set release status flags based on info from the regressing bug 1801379

status-firefox114: --- → affected

https://treeherder.mozilla.org/logviewer?job_id=417679162&repo=autoland

[task 2023-05-31T18:46:23.391Z] 18:46:23     INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js | There should not be a ready update - 
[task 2023-05-31T18:46:23.391Z] 18:46:23     INFO - Buffered messages finished
[task 2023-05-31T18:46:23.393Z] 18:46:23     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js | Uncaught exception in test bound aboutPrefs_internalError - at chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:1156 - ReferenceError: BrowserTestUtils is not defined
[task 2023-05-31T18:46:23.393Z] 18:46:23     INFO - Stack trace:
[task 2023-05-31T18:46:23.393Z] 18:46:23     INFO - @chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:1156:15
[task 2023-05-31T18:46:23.393Z] 18:46:23     INFO - execute@resource://testing-common/SpecialPowersSandbox.sys.mjs:139:12
[task 2023-05-31T18:46:23.393Z] 18:46:23     INFO - _spawnTask@resource://testing-common/SpecialPowersChild.sys.mjs:1654:15
[task 2023-05-31T18:46:23.393Z] 18:46:23     INFO - receiveMessage@resource://testing-common/SpecialPowersChild.sys.mjs:261:21
[task 2023-05-31T18:46:23.393Z] 18:46:23     INFO - JSActor query*receiveMessage@resource://testing-common/SpecialPowersParent.sys.mjs:1396:14
[task 2023-05-31T18:46:23.393Z] 18:46:23     INFO - JSActor query*spawn@resource://testing-common/SpecialPowersChild.sys.mjs:1583:17
[task 2023-05-31T18:46:23.394Z] 18:46:23     INFO - runAboutPrefsUpdateTest/processAboutPrefsStep/<@chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:1127:27
[task 2023-05-31T18:46:23.394Z] 18:46:23     INFO - async*processAboutPrefsStep@chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:1197:7
[task 2023-05-31T18:46:23.394Z] 18:46:23     INFO - runAboutPrefsUpdateTest/<@chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:1272:13
[task 2023-05-31T18:46:23.394Z] 18:46:23     INFO - async*runAboutPrefsUpdateTest@chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:1274:5
[task 2023-05-31T18:46:23.394Z] 18:46:23     INFO - aboutPrefs_internalError@chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js:30:9
[task 2023-05-31T18:46:23.394Z] 18:46:23     INFO - handleTask@chrome://mochikit/content/browser-test.js:1133:26
[task 2023-05-31T18:46:23.394Z] 18:46:23     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1205:18
[task 2023-05-31T18:46:23.394Z] 18:46:23     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1347:14
[task 2023-05-31T18:46:23.394Z] 18:46:23     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1122:14
[task 2023-05-31T18:46:23.394Z] 18:46:23     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-05-31T18:46:23.394Z] 18:46:23     INFO - Leaving test bound aboutPrefs_internalError
[task 2023-05-31T18:46:23.660Z] 18:46:23     INFO - GECKO(6476) | MEMORY STAT | vsize 2112654MB | vsizeMaxContiguous 65323280MB | residentFast 417MB | heapAllocated 206MB
[task 2023-05-31T18:46:23.669Z] 18:46:23     INFO - TEST-OK | toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js | took 941ms
Summary: Intermittent TV toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js | single tracking bug → Intermittent toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js | single tracking bug

I think the latest spike may be a regression from bug 1835559. BrowserTestUtils.waitForEvent is sometimes being used to try to wait for L10n to finish, but I believe that BrowserTestUtils is not available within SpecialPowers.spawn scopes.

Flags: needinfo?(rob)

Thanks, I should have used ContentTaskUtils.waitForEvent instead.

Flags: needinfo?(rob)

This fixes two test issues:

  • Use ContentTaskUtils.waitForEvent instead of
    BrowserTestUtils.waitForEvent for the part of the test that runs in a
    SpecialPowers.spawn environment - fixes bug 1825228.
  • Await l10n translation completion in another place that was missed in
    the patch to bug 1835559. Fixes bug 1836504.
Duplicate of this bug: 1836162
Duplicate of this bug: 1836169
Duplicate of this bug: 1836190
Duplicate of this bug: 1836504
Summary: Intermittent toolkit/mozapps/update/tests/browser/browser_aboutPrefs_internalError.js | single tracking bug → Intermittent toolkit/mozapps/update/tests/browser/browser_aboutPrefs_<smth>.js | single tracking bug
Assignee: nobody → rob
Status: NEW → ASSIGNED
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/9b3d8614469e Correctly await l10n completion in update tests r=application-update-reviewers,nalexander
Duplicate of this bug: 1836593

https://hg.mozilla.org/mozilla-central/rev/9b3d8614469e

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

I will take this test only change in a beta uplift.

status-firefox114: fix-optional → wontfix
status-firefox115: --- → affected
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: