[CTW] Hit testing overflow:hidden; nodes is incorrect
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
People
(Reporter: morgan, Assigned: morgan)
References
(Blocks 2 open bugs)
Details
Attachments
(4 files)
STR:
- Load the
data:text/html,<style> div div { overflow: hidden; font-family: monospace; width: 2ch; } </style><div style="display: flex; flex-direction: row-reverse;"><div>abcde</div><div>fghij</div>
with CtW on - Hit test "fg"
Expected: We receive "fg" as a hittest result
Actual: Hit testing reports the entire acc, including the hidden portions (fghij)
- Hit test "ab"
Expected: we get "ab"
Actual: we get the "fg" node
Comment 1•2 years ago
|
||
(In reply to Morgan Reschenberg [:morgan] from comment #0)
Actual: Hit testing reports the entire acc, including the hidden portions (fghij)
I don't quite get this bit. Hit testing for the acc (ChildAtPoint) reports the "fghij"text Accessible, which makes sense; we can't get any smaller than that. The client then has to call OffsetAtPoint with the point in question to determine which character it's interested in.
However, hit testing h, i or j with ChildAtPoint shouldn't report the fg Accessible.
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
Assignee | ||
Comment 3•2 years ago
|
||
Depends on D175193
Assignee | ||
Comment 4•2 years ago
|
||
Depends on D175194
Assignee | ||
Comment 5•2 years ago
|
||
Depends on D175195
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Comment 7•2 years ago
|
||
Backed out for causing multiple mochitest failures.
Assignee | ||
Comment 8•2 years ago
|
||
Comment 10•2 years ago
|
||
Backed out for causing mochitests failures in accessible/tests.
- Failure Log - ba
- Failure line: TEST-UNEXPECTED-FAIL | accessible/tests/browser/tree/browser_general.js | Test timed out -
- Failure Log - a11y
- Failure line: TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/actions/test_media.html | Scenario #0 of test with ID = 'name change handling' failed. 'name changed event is missed.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 11•2 years ago
|
||
Comment 12•2 years ago
|
||
Comment 13•2 years ago
|
||
Backed out with Bug 1828373 and Bug 1825411 for accessible failures on on /browser_general.js
- backout: https://hg.mozilla.org/integration/autoland/rev/8d8d99e7581851de698e27339dffd60ee8dc8e32
- push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=fa9772a45927f265c2eb2fa7301061c3406441f9
- failure log: https://treeherder.mozilla.org/logviewer?job_id=414559862&repo=autoland&lineNumber=4569
[task 2023-05-03T23:03:41.235Z] 23:03:41 INFO - TEST-PASS | accessible/tests/browser/tree/browser_general.js | Wrong last child of [role: text leaf, name: 'hello world', address: [xpconnect wrapped nsIAccessible]] -
[task 2023-05-03T23:03:41.236Z] 23:03:41 INFO - Adding overflow:hidden styling to div
[task 2023-05-03T23:03:41.236Z] 23:03:41 INFO - Buffered messages finished
[task 2023-05-03T23:03:41.237Z] 23:03:41 INFO - TEST-UNEXPECTED-FAIL | accessible/tests/browser/tree/browser_general.js | Test timed out -
[task 2023-05-03T23:03:41.455Z] 23:03:41 INFO - GECKO(5468) | MEMORY STAT | vsize 2104178MB | vsizeMaxContiguous 66514862MB | residentFast 236MB | heapAllocated 91MB
[task 2023-05-03T23:03:41.459Z] 23:03:41 INFO - TEST-OK | accessible/tests/browser/tree/browser_general.js | took 46426ms
Comment 14•2 years ago
|
||
Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/8d8d99e75818
Assignee | ||
Updated•2 years ago
|
Comment 15•2 years ago
|
||
Comment 16•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/69b67a4f7465
https://hg.mozilla.org/mozilla-central/rev/f008e16e684c
https://hg.mozilla.org/mozilla-central/rev/a819a38858ad
https://hg.mozilla.org/mozilla-central/rev/29d02d013170
Updated•2 years ago
|
Updated•2 years ago
|
Comment 17•1 years ago
|
||
The patch landed in nightly and beta is affected.
:morgan, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.Also, don't forget to request an uplift for the patches in the regressions caused by this fix.
- If no, please set
status-firefox114
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Updated•1 years ago
|
Updated•1 years ago
|
Comment 18•1 year ago
|
||
backed out in 115 beta (115.0rc1) for causing bug 1840200 (backout patch is in bug 1840200)
Comment 19•1 year ago
|
||
I was able to reproduce the issue on Mac 12.6 using FF build 115.0, using below steps:
- Enable VoiceOver, In VoiceOver Utility.app > Navigation ensure "Synchronise VO focus and mouse cursor" is checked
- Load the provided test case
- Mouseover "fg" with VoiceOver enabled
Expected:
VO reports "fg" only
Actual:
VO reports all on-screen text.
Verified that issue is fixed on Mac 12.6 using FF build 116.0a1(20230627214548).
Description
•