Closed Bug 1825841 Opened 2 years ago Closed 2 years ago

Issues with aboutDialog on Flatpak builds

Categories

(Thunderbird :: Build Config, defect)

Thunderbird 112
All
Linux
defect

Tracking

(thunderbird113 fixed)

RESOLVED FIXED
114 Branch
Tracking Status
thunderbird113 --- fixed

People

(Reporter: dandarnell, Assigned: rjl)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

The Thunderbird console contains some unnecessary messages regarding the updater, which is not used by the Flatpak version of Thunderbird. This should be removed.

Assignee: daniel → rob

More specifically, I occasionally see a message about "panel" being undefined at line 208 of aboutDialog-appUpdater.js. It's inconsistent though.

A bigger problem is the about dialog is not stating that it's a Flatpak build, when it should be reading that from distribution.ini. So that's a problem as well.

Attached image image.png (deleted) —
Summary: Stop updater console spam for Thunderbird Flatpak → Issues with aboutDialog on Flatpak builds
Type: task → defect
Keywords: regression
Regressed by: 1816532

Fixes a regression from bug 1816532 that caused information from distribution.ini
to no longer be displayed in the About dialog. This will pertain to repackaged
builds such as Flatpak and MSIX as well as any Linux distribution that includes
a distribution.ini file.

Drive-by fix: When MOZ_UPDATER is not set at build time, or a packaged application
(Flatpak, Snap, MSIX) is detected, there is a big empty space in the middle of
the dialog that is removed by setting the max-height of #updateDeck to 0. This
is triggered by STATUS.NO_UPDATER, which is set only under those conditions.

Status: NEW → ASSIGNED

Comment on attachment 9330731 [details]
Bug 1825841 - Fix inclusion of distribution info in About dialog. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Fixes missing information from distribution.ini that should be in the About Dialog.
This potentially affects more than Flatpak. Linux distros tend to use this file as well.

Attachment #9330731 - Flags: approval-comm-beta?
Target Milestone: --- → 114 Branch

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/161432526a62
Fix inclusion of distribution info in About dialog. r=leftmostcat

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Comment on attachment 9330731 [details]
Bug 1825841 - Fix inclusion of distribution info in About dialog. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Attachment #9330731 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: