Issues with aboutDialog on Flatpak builds
Categories
(Thunderbird :: Build Config, defect)
Tracking
(thunderbird113 fixed)
Tracking | Status | |
---|---|---|
thunderbird113 | --- | fixed |
People
(Reporter: dandarnell, Assigned: rjl)
References
(Blocks 2 open bugs, Regression)
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
Bug 1825841 - Fix inclusion of distribution info in About dialog. r=#thunderbird-front-end-reviewers
(deleted),
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
|
Details |
The Thunderbird console contains some unnecessary messages regarding the updater, which is not used by the Flatpak version of Thunderbird. This should be removed.
Reporter | ||
Updated•2 years ago
|
Reporter | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
More specifically, I occasionally see a message about "panel" being undefined at line 208 of aboutDialog-appUpdater.js. It's inconsistent though.
A bigger problem is the about dialog is not stating that it's a Flatpak build, when it should be reading that from distribution.ini. So that's a problem as well.
Assignee | ||
Comment 2•2 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Fixes a regression from bug 1816532 that caused information from distribution.ini
to no longer be displayed in the About dialog. This will pertain to repackaged
builds such as Flatpak and MSIX as well as any Linux distribution that includes
a distribution.ini file.
Drive-by fix: When MOZ_UPDATER is not set at build time, or a packaged application
(Flatpak, Snap, MSIX) is detected, there is a big empty space in the middle of
the dialog that is removed by setting the max-height of #updateDeck to 0. This
is triggered by STATUS.NO_UPDATER, which is set only under those conditions.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
Comment on attachment 9330731 [details]
Bug 1825841 - Fix inclusion of distribution info in About dialog. r=#thunderbird-front-end-reviewers
[Approval Request Comment]
Fixes missing information from distribution.ini that should be in the About Dialog.
This potentially affects more than Flatpak. Linux distros tend to use this file as well.
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/161432526a62
Fix inclusion of distribution info in About dialog. r=leftmostcat
Comment 6•1 years ago
|
||
Comment on attachment 9330731 [details]
Bug 1825841 - Fix inclusion of distribution info in About dialog. r=#thunderbird-front-end-reviewers
[Triage Comment]
Approved for beta
Reporter | ||
Comment 7•1 years ago
|
||
bugherder uplift |
Thunderbird 113.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/3bc2b9089563
Description
•