Closed
Bug 1826734
Opened 2 years ago
Closed 1 year ago
Replace mozilla::Unused with (void) in DOM: File components
Categories
(Core :: DOM: File, task)
Core
DOM: File
Tracking
()
RESOLVED
FIXED
115 Branch
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | fixed |
People
(Reporter: saschanaz, Assigned: saschanaz)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Updated•2 years ago
|
Summary: Replace mozilla::Unused with (void) in dom/file → Replace mozilla::Unused with (void) in DOM: File components
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Comment 2•1 year ago
|
||
There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:saschanaz, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Flags: needinfo?(krosylight)
Flags: needinfo?(bugmail)
|
|
Assignee | |
Comment 3•1 year ago
|
||
Two weeks?! No way, time flies!
I wonder it should warn with NS_WARN_IF(FAILED()) or QM_WARNONLY_TRY instead of just fully ignore the result.
Flags: needinfo?(krosylight)
Flags: needinfo?(bugmail)
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96e1951eae03 Replace mozilla::Unused with (void) in dom/{file,filesystem} r=dom-storage-reviewers,asuth
|
||
Comment 5•1 year ago
|
||
(In reply to Kagami [:saschanaz] from comment #3)
I wonder it should warn with
NS_WARN_IF(FAILED())orQM_WARNONLY_TRYinstead of just fully ignore the result.
There is already an NS_WARN_IF internally in DispatchToIOThread:
if (NS_WARN_IF(NS_FAILED(rv))) {
return rv;
}
|
||
Comment 7•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox115:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•