Unable to change/disable video subtitles after playback started, subtitle menu closes before mouse pointer reaches it
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox112 | --- | unaffected |
| firefox113 | + | verified |
| firefox114 | + | verified |
People
(Reporter: jan, Assigned: emilio)
References
(Regression)
Details
(Keywords: nightly-community, regression)
Attachments
(4 files)
|
(deleted),
video/webm
|
Details | |
|
(deleted),
video/webm
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
KDE Wayland, Debian Testing
I can't change/disable subtitles anymore. It's as if there is space between the CC button and the subtitle menu and then it closes when I unhover the CC button.
mozregression --good 2023-02-01 --bad 2023-04-11 -a https://brenopolanski.github.io/html5-video-webvtt-example/
9:43.09 INFO: Last good revision: be6ab6cd894d8c24ff38dca59c1820ef8c51a831
9:43.09 INFO: First bad revision: 4d6b19e4c8bdd48e2553678ca95add19f6a0eedf
9:43.09 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=be6ab6cd894d8c24ff38dca59c1820ef8c51a831&tochange=4d6b19e4c8bdd48e2553678ca95add19f6a0eedf
4d6b19e4c8bdd48e2553678ca95add19f6a0eedf Emilio Cobos Álvarez — Bug 1825825 - Tweak DevTools walker to preserve behavior after the previous patches. r=devtools-reviewers,nchevobbe
0d254cc9e9c4a17c2d8a9af63bbac57e81cb84d9 Emilio Cobos Álvarez — Bug 1825825 - Simplify NAC setup. r=smaug
|
Assignee | |
Updated•2 years ago
|
|
Reporter | |
Comment 1•2 years ago
|
||
Same regression range:
Hovering the area of the video control bar doesn't unhide it anymore.
Now, the mouse pointer must hover the video above the control bar to unhide the control bar.
|
|
Assignee | |
Comment 2•2 years ago
|
||
Yep, I'm looking into this, I just had to fix the debugger first lol.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 4•2 years ago
|
||
No behavior change here, but I was looking and this code can be simpler.
|
|
Assignee | |
Comment 5•2 years ago
|
||
The continue in GetContentInThisDocument meant that if we call that in a
UA widget we'd return null...
This breaks the following check:
Which was introduced in bug 1513600 to fix precisely this bug...
Depends on D175714
|
|
Assignee | |
Comment 6•2 years ago
|
||
Comment on attachment 9328948 [details]
Bug 1827516 - Fix retargeting of UAWidget.elementFromPoint(). r=smaug
Beta/Release Uplift Approval Request
- User impact if declined: See comment 0 and dupe
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: comment 0 and bug 1828332 show examples of this.
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Relatively straight-forward change.
- String changes made/needed: none
- Is Android affected?: Yes
|
|
Assignee | |
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/972e233cb181
https://hg.mozilla.org/mozilla-central/rev/e2222a8b3390
|
||
Updated•2 years ago
|
|
|
Reporter | |
Updated•2 years ago
|
|
|
||
Comment 9•2 years ago
|
||
Comment on attachment 9328948 [details]
Bug 1827516 - Fix retargeting of UAWidget.elementFromPoint(). r=smaug
Approved for 113.0b6.
|
|
||
Comment 10•2 years ago
|
||
| bugherder uplift | ||
|
||
Comment 11•2 years ago
|
||
Reproduced the issue with Firefox 114.0a1 (20230416211848) on Windows 10x64 by following STR from comment 0 and from bug 1828332. The subtitles cannot be changed and the video controls are not displayed when entering the video area from the bottom.
The issue is verified fixed with Firefox 114.0a1 (2023-04-19) and 113.0b6 (20230419174221) from comment 10 on Windows 10x64, macOS 12 and Ubuntu 22.04. The subtitles can be successfully changed and the video controls are displayed when entering the video area from the bottom or when changing the seek bar position.
Description
•