Closed
Bug 1828955
Opened 1 year ago
Closed 1 year ago
Implement "Feedback" result menu button for weather suggestions
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
114 Branch
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | verified |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(2 files)
feedback-menu.png
No description provided.
|
Assignee | |
Comment 1•1 year ago
|
||
This makes the following changes to the result menu button for weather results:
- Add a "Feedback" label
- Make it always visible
We may want to use this feedback button for other types of results, so I added a
generalized way for results to opt into it, result.showFeedbackMenu.
See Figma
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12acae655a05
Implement "Feedback" result menu button for weather suggestions. r=dao,bolsson
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox114:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
|
|
Assignee | |
Updated•1 year ago
|
Flags: qe-verify+
Flags: in-testsuite-
|
|
Assignee | |
Comment 4•1 year ago
|
||
STR for QA: Trigger the weather suggestion and click the Feedback button. The button and menu should look like this screenshot, which is from Windows but each platform looks similar.
|
||
Comment 5•1 year ago
|
||
I have verified this issue on the latest Firefox Nightly 115.0a1 (Build ID: 20230508214159) and Beta 114.0b1 (Build ID: 20230508175934), on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.
- The "Feedback" label is displayed inside the menu button.
- The menu and sub-menu options are the same as in the screenshot from comment 4:
Report inaccurate location
Show less frequently
Don't show this - Not relevant & Not interested
Learn more about Firefox Suggest
You need to log in
before you can comment on or make changes to this bug.
Description
•