do not schedule tasks that have no active tests when pushing to try with custom paths
Categories
(Testing :: General, enhancement, P2)
Tracking
(firefox114 fixed)
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
there are a few cases where pushing to try and scheduling a path can yield a list of tasks that are orange due to no tasks ran. Here is an example:
./mach try fuzzy -q "'debug | 'opt" browser/base/content/test/static toolkit/components/pdfjs/test
One major cause here is we have manifests that reference tests from another directory:
https://searchfox.org/mozilla-central/source/devtools/client/framework/test/browser.ini#172-176
So our logic for chunking/test selection doesn't account for that.
A simple fix is to keep track of these manifests that reference other directories and are active for the given task, then when we find a scenario that we are running specific paths, we can check to see if the paths are referenced in the other directories- if they are we know they are active and can keep scheduling the task, if there are no references then we can remove the task from the list to be scheduled.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Description
•