Closed
Bug 1829139
Opened 2 years ago
Closed 2 years ago
Expire from history non-typed hidden single-visit URIs older than 90 days
Categories
(Toolkit :: Places, task, P3)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
114 Branch
Tracking | Status | |
---|---|---|
firefox114 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
This investigation started because I noticed many timed out transactions in expiration, and one obvious thing here is we're sending notifications inside the transaction. So I'm moving those notifications out of the database transaction.
I'm also optimizing the exotic visits query, that is quite slow due to the LENGTH(url) check, so I am limiting it to urls with visit_count = 1.
While there, we could expire a little bit more, and non-typed hidden single-visit URIs look like an opportunity.
I'm finally increasing the time to 90 days, since there have been various requests to have a longer expiration time for downloads, this also makes the resultset to examine a bit smaller, helping with perf.
Assignee | ||
Comment 1•2 years ago
|
||
This included multiple changes:
- Expire old non-typed hidden single-visit URIs
- Expire long urls only if they are single-visit
- increase the necessary age for expiration to 90 days
- stop notifying listeners inside the database transaction
Assignee | ||
Updated•2 years ago
|
Summary: Expire from history non-typed hidden single-visit URIs older than 60 days → Expire from history non-typed hidden single-visit URIs older than 90 days
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/ae64c7092f40
Optimizations to old visits expiration. r=Standard8
Comment 3•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox114:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•