Closed Bug 1829667 Opened 2 years ago Closed 1 year ago

Make JsepTransceiver non-refcounted, and stop sharing references to them

Categories

(Core :: WebRTC: Signaling, task)

task

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

Details

Attachments

(2 files)

Access to the JsepTransceivers in JsepSession ought to be tightened up, especially now that they have proper identifiers (see bug 1769802). Most access ought to be by value, and failing that, using functional-style modifications so that references aren't allowed to persist beyond their intended scope.

Assignee: nobody → docfaraday
Status: NEW → ASSIGNED

Involves substantial refactoring to make most access by-value (or through
functional-style in-place modifications) for safety.

Depends on D176422

Wpt push is permabusted here too... maybe I need to rebase...

Rebase didn't help. This is stuck until we can get the problem with wpt try resolved.

Flags: needinfo?(ahal)
Flags: needinfo?(ahal)
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0cfd10fcb68d Fix a bug in the assignment operator, and also a const-correctness fix. r=mjf https://hg.mozilla.org/integration/autoland/rev/6e8fbf07f4b9 Make JsepTransceiver non-refcounted. r=mjf,webidl,mccr8
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
Regressions: 1830724
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: