Closed
Bug 1829987
Opened 2 years ago
Closed 2 years ago
Handle null and undefined as keys in MegamorphicLoadSlotByValue
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
114 Branch
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: dthayer, Assigned: dthayer)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
These show up somewhat prominently, and we enter into kind of a pathological state because of it, where CacheIR.cpp believes that MegamorphicLoadSlotByValue can handle it, but the actual MegamorphicLoadSlotByValue can't. We need to bring them in sync.
|
Assignee | |
Comment 1•2 years ago
|
||
Saw a 2% speedometer 2 improvement and a 2% matrix-react improvement.
Speedometer 3 didn't like it because react-stockcharts is super bimodal, which
is annoying, but I'm going to call this a win.
|
||
Updated•2 years ago
|
Assignee: nobody → dothayer
Status: NEW → ASSIGNED
Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c648f117826
Handle null and undefined keys in megamorphic GetElem r=iain
|
||
Updated•2 years ago
|
Whiteboard: [sp3]
|
||
Updated•2 years ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-355
|
||
Updated•2 years ago
|
Severity: -- → S3
Priority: -- → P1
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox114:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•