Closed Bug 1830319 Opened 1 year ago Closed 1 year ago

Ignore blackboxed sources when tracing javascript

Categories

(DevTools :: Debugger, enhancement)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox115 fixed)

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

Bug 1830319 - [devtools] Avoid logging frames of blackboxed sources.
(deleted), text/x-phabricator-request
Details

The JavaScript tracer introduced in bug 1803616 currently doesn't consider blackboxing information. We should avoid logging javascript frames related to sources currently ignored by the debugger.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e72a948564df [devtools] Avoid logging frames of blackboxed sources. r=devtools-reviewers,bomsy

Backed out for causing mochitest failures in devtools/client/debugger/test/mochitest/browser_dbg-javascript-tracer.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5dec304d7876a1c8c9732b1621e4f4ca8b5cbadf

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-javascript-tracer.js | Test timed out -

Flags: needinfo?(poirot.alex)

Oops this required a small tweak to acknowledge a recent change made to blackbox redux actions.

Flags: needinfo?(poirot.alex)
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62292cc71831 [devtools] Avoid logging frames of blackboxed sources. r=devtools-reviewers,bomsy

https://hg.mozilla.org/mozilla-central/rev/62292cc71831

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: