1830535 - The Top Picks result for Research Gate has a broken favicon

Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until September 8th)

Reporter

Description

•

2 years ago

Attached image Screenshot_5.png (deleted) — Details

[Affected versions]:

Nightly 114.0a1
Beta 113.0b8
Firefox 12.0.1

[Affected Platforms]:

Mac 12.4
Windows 10 x64
Linux Mint 20

[Prerequisites]:

Have a new profile with the following prefs set:
browser.search.region to US
browser.urlbar.quicksuggest.dataCollection.enabled to true
browser.urlbar.merino.providers to adm,top_picks
browser.urlbar.bestMatch.enabled to true

[Steps to reproduce]:

Open the Nightly browser with the profile from the prerequisites.
Type "research" in the awesome bar.
Observe the Top Pick's favicon.

[Expected result]:

The favicon is correctly displayed.

[Actual result]:

The favicon is broken.

[Notes]:

So far I have found only this result with a broken favicon. I haven't managed to go through all the results and I am not sure if there are any other broken favicons.
Attached is a screenshot of the issue.

Nan Jiang [:nanj]

Comment 1

•

2 years ago

Looks like the image contains a script:

curl -v https://merino-images.services.mozilla.com/favicons/bfbac6c5acc401b25711a64abaab462ebb15950d5f84f215bd765414749abb69_7318.oct                                           ─╯
*   Trying 34.110.253.53:443...
* Connected to merino-images.services.mozilla.com (34.110.253.53) port 443 (#0)
* ALPN: offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN: server accepted h2
* Server certificate:
*  subject: CN=prodpy-images.merino.prod.cloudops.mozgcp.net
*  start date: Mar 10 23:40:16 2023 GMT
*  expire date: Jun  8 23:40:15 2023 GMT
*  subjectAltName: host "merino-images.services.mozilla.com" matched cert's "merino-images.services.mozilla.com"
*  issuer: C=US; O=Let's Encrypt; CN=R3
*  SSL certificate verify ok.
* using HTTP/2
* h2h3 [:method: GET]
* h2h3 [:path: /favicons/bfbac6c5acc401b25711a64abaab462ebb15950d5f84f215bd765414749abb69_7318.oct]
* h2h3 [:scheme: https]
* h2h3 [:authority: merino-images.services.mozilla.com]
* h2h3 [user-agent: curl/8.0.1]
* h2h3 [accept: */*]
* Using Stream ID: 1 (easy handle 0x11f813000)
> GET /favicons/bfbac6c5acc401b25711a64abaab462ebb15950d5f84f215bd765414749abb69_7318.oct HTTP/2
> Host: merino-images.services.mozilla.com
> user-agent: curl/8.0.1
> accept: */*
>
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* old SSL session ID is stale, removing
< HTTP/2 200
< x-guploader-uploadid: ADPycdvbZuHGPt31XS5R3rubnDhAOFkzLFux5yRVhLhRxNkVJrVG_ptMlhgTsJK11dCvM_JysYyKtQEbDnApnbR39BycGUtahCRB
< x-goog-generation: 1683015285312793
< x-goog-metageneration: 2
< x-goog-stored-content-encoding: identity
< x-goog-stored-content-length: 7318
< x-goog-hash: crc32c=i9Vp2A==
< x-goog-hash: md5=UePkWrxmUqjK63gmHdH4rg==
< x-goog-storage-class: STANDARD
< accept-ranges: bytes
< content-length: 7318
< server: UploadServer
< date: Tue, 02 May 2023 15:20:48 GMT
< last-modified: Tue, 02 May 2023 08:14:45 GMT
< etag: "51e3e45abc6652a8caeb78261dd1f8ae"
< content-type: text/html; charset=UTF-8
< age: 484
< cache-control: public,max-age=3600
< strict-transport-security: max-age=31536000
< alt-svc: clear
<
<!DOCTYPE html>
<html lang="en-US">
<head>
    <title>Just a moment...</title>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=Edge">
    <meta name="robots" content="noindex,nofollow">
    <meta name="viewport" content="width=device-width,initial-scale=1">
    <link href="/cdn-cgi/styles/challenges.css" rel="stylesheet">


</head>
<body class="no-js">
    <div class="main-wrapper" role="main">
    <div class="main-content">
        <noscript>
            <div id="challenge-error-title">
                <div class="h2">
                    <span class="icon-wrapper">
                        <div class="heading-icon warning-icon"></div>
                    </span>
                    <span id="challenge-error-text">
                        Enable JavaScript and cookies to continue
                    </span>
                </div>
            </div>
        </noscript>
        <div id="trk_jschal_js" style="display:none;background-image:url('/cdn-cgi/images/trace/managed/nojs/transparent.gif?ray=7c0ecffc8801ebbb')"></div>
        <form id="challenge-form" action="/favicon-96x96.png?__cf_chl_f_tk=ZG0OLbR.mKQoi5qOpVQGBc4_eScAhLCqPXRe829pYqE-1683015285-0-gaNycGzNCqU" method="POST" enctype="application/x-www-form-urlencoded">
            <input type="hidden" name="md" value="X9bvW_sDeEY5LR0WR96idciIFg62ebXpunOVlX.H7XU-1683015285-0-AaAKeytZRXCXFgvs0bLbT52rlL88tujNXvdo93l8itnXUIpZCmMZeyi-hPQtVhE7euT5Dtc7rVnY8boT8u9UZ4_19WMGWZS9AsT4DJANIy5TFSByWpbDCSJIa0olhs1geNywF1ubOhAIOimZNwPXRffV0t8dkAuFWhjEH-5Fjb2PLvePmd9noksFCxn9KGRBedpc8wc0r2QXdYHRZAihXuw84U3Vj6H41GQKJ88VqnZ8qd2LcLR5iTH9TiEjwhdSfXOEpU7pyR7Ttw2swIuampHp6zFVayHO5rgV26rndc48UqhyQmTMWr5F3ZYbAnZmW3S4PCCnZfoDqUHk9gO-zTkhDO6VhIpJQeOGLP7H0nBOx8OGWGSQ5vK9uXVvSPOlPcWQiVXl3E9PkDjo2r7SyXD8LJjhICnQaP4m1NFR_ZANBXVTLd5ApJ_lHlsRhi0bgMzi-TVCKfdSuweDcKd7vruJ9C6c2UILeIjYpUIlvS9Er9N7CwCup7a2R1Jtqp-6HRHT5n-9u0QejdiL06_QyUDIrF49fmz6owRoOe2JJNoyHtKOIZxl7UIEAwysTvUlzeg-3G1RciA9_VHE304E4p2lZrxFEiDwAbHW51Y5nsocdST6weva_8-_cfWxJ2o47UPCnY5QU9mj4NtgB5tbFglU9t2RBKA-v9Zdf2h2aQVG13xw_Vhrj-TdzZej2XzxdFbx5AaW_Uz5XPv7kdGlvnrtQYMqHwK4ZrGF2XOiKS7pGfvt37PxauOigaX1m5JtqNNaYLs8OBQYYTwTrZEy-6hEHj4xdNeUUqjswrO_dAk9avkZ8Vv9kF2VGDfRxjMVb0txBEr2V0EqpRAFr_pRJt7tX9i3qd_pbD555gTzNZ07GZqoixtDtXyw9lKelLacwF_UQ8_cMv29Ht0vTnQmFWrf0REXuH_eRBq8vEvxHuWEJK8VimcpIwi4GbRbTxMsvq4I-wOpNB5ui_Yl-ih2DHMzpQOYE74csFpq4TD3MkQjpCTpdocT27xhIz_nNVECEXbiqTNqEoZDWnHZQpIBsaS-SeRDWBnj1I3uaPFynbbMfktfdAc60WjNAv1KYxTCPa-HWZwzrpTBBnqyyhttmnXWNivvO84VyNV8nmInmW78XKrfS_zfkLQxF_ul3YV9CvulIxSWwOzjCSCYhJocMvbrWBqcdhpRJGfsllE2hxSmzhrJBMjr2uYv9S65K5w_WA1fZ-DB14s9f5xa1u56aAizQdC3wpF6tUQoZfr7Yq_FBhD3j3eB5bs9tSaeVlnmz0ZnZkgKRYhkJgh5JU45MLPYea6LIgS3-1GW_q0iLnpJ6KjXnZygjqY5TYmAMJ3OM4snyVuZs1K_4wYeYIAYGXoE8lgNJZgTS8sWiQjUZgE0RyTvQ1b183cLnZ_Zx71IzYwQRnhpa-tctazA10_5U-MWwIajFrybHTVENR-mpNl2YBtjlBZItz61E76LM9CV9WsS4ltFg9iNm5Q0WfsfZLYGog4rj1IOw7S0WSMuS0YLGBSbqbPIAjscgNKmsTPHEqCHX_Esk8ZI71cdnU7-1m1xWJbrAENgFetKmGFnINhoCOdxXLH28x2n2h3-Ai-7z1VRdpwfBJpcapD59wE7lphRkilbZNUecQ3zyX7TzNzepCWlabQbnKkmx5DU3kiF54gqG7oRxNVhW9jwuk1kABzT5NAzLom6CrOFQQ4pVEa3EMhnxqglAYp-xvzQbCO5zdoEKWUg_nFBYmVwG5o1xsPxMsockQ9gM2atnqpgSJBbHMppHFmi_xvB7VXtgsBvtQVRedWVVbqE-DO7PjVNANBMhTWdQgEP0DuGn3h-qApaJXcrMvrsD_31uu8jAwS8Hlg0_FJND3muFcG2IaNcKAVucD95d7ZZiZmfLCTkMLV-AfwJ8Rv_W44T7fjJ_G7UZ8VRPZS8Eo6GFz5FOxPGfWv34vs-d8i0s7ZIXyymfXqJ2433441xGIBo27Obdl9DhM5XlX0nj0fI-eiQW-m0IRZfc9_5H0om2_SN3zYLa1nCFFK5vqiah8Z2YdCUMlQX_bA2McWX8TU0-I3oAyQa7y2XxQX6zUyKXn9X5YHZZe5w5FGvk_snElDERJqfQOTWvJOa_OkR0YsfSqlxyTmjmHA4GF4WmpG3XUEw8-jx2kJEiKV5_5p4-nE_bLhqzmInwoPxNBwiA82m6o9W2L25Wb_U_Ayh3rVXOChLEUnuV7LBqdlyj2u89bXXPx5nI9aCxS3o-Yli8ktuLxbr4HlAAogQda0hkMq38HAVoIQyAnTGcoEo7zzWHjHM9q6He-hNlaD8WrzlKuOkBRAXXDPGrU9qtCTp3hjtArIooiAleUavORh32rLYjqkIkPq9FKp52bkaQ2JuwhCFLagNaiWQ4cxTm8jvISC_DczsRZzQZo3f9X3EKDiJVIcLL3MWrDwBUlBoHatSBT6Qv6qvDBFUqfcVg6Coe0OHxlnElJTlEdwz_h0x7k_V-9RPXI-xa88-8c8on5c3UP0jDq9NrpcY-DYAjvjfiOV_doTwi9Xe39biRFxGai9_HkT3nUQF3us6mp5oEsiSz_a2btQnb3UUe_SyVnPb_li_IE7u50iONM54cMrgExomJQfIpAe3N7jJXfpTm1iCTVK-0_1HTZWK0GFsmVYdS8KZRfTv8OoLptJl">
        </form>
    </div>
</div>
<script>
    (function(){
        window._cf_chl_opt={
            cvId: '2',
            cZone: 'www.researchgate.net',
            cType: 'managed',
            cNounce: '70921',
            cRay: '7c0ecffc8801ebbb',
            cHash: 'e8737fc298f2931',
            cUPMDTk: "\/favicon-96x96.png?__cf_chl_tk=ZG0OLbR.mKQoi5qOpVQGBc4_eScAhLCqPXRe829pYqE-1683015285-0-gaNycGzNCqU",
            cFPWv: 'g',
            cTTimeMs: '1000',
            cMTimeMs: '0',
            cTplV: 5,
            cTplB: 'cf',
            cK: "",
            cRq: {
                ru: 'aHR0cHM6Ly93d3cucmVzZWFyY2hnYXRlLm5ldC9mYXZpY29uLTk2eDk2LnBuZw==',
                ra: 'TW96aWxsYS81LjAgKE1hY2ludG9zaDsgSW50ZWwgTWFjIE9TIFggMTMuMzsgcnY6MTExLjApIEdlY2tvLzIwMTAwMTAxIEZpcmVmb3gvMTExLjA=',
                rm: 'R0VU',
                d: 'idfBmwvLBK9+TW4PhmiiMP5KDO9WmxKpvl27ljf9RF6wkbE5xxXxbBdebB2LO9r6ePux6xzAVDjkNaTEpfcWATQ9eexJf5SLO+Cd9UWcvRWCgFbGk2p5A11QXKXc7yzl4oXVthwF01tnl/PpVUZwamarZ3XVLjSMAM5yVQNc3AfcnYhlJes1qFvNQD2s9C6kBl8eSyxI7l7YddSaYsL0U3yPRzyhAWGInQWCoVtfRM1LPRCyRktwsE35NCGMm9RSEqG3y8QpoR7hqW3QIkojafeQWKnuUkSyI3k7uvYq9yPQ7/Oln/PmulzqdNouPeY+FANNWrusterpwwajVPE6dxNYz8Ng3R8OQlvRHFfdg389RKK6sul0HucyoD0BRIOv6aIjWYmvo/31+EwUU/gh69Gu0bXUXrX3gxKiKixcusRrrnlNinM4+ULBKK7M4OpzmKaQH6pBd0aj8EhbX1xZvHfCYSqH7c3iodMjhUsXxKBilcPhwmI1fUSeWs9xM7BwIqCdcPNS1wkQKVFt2uwNS0Pjz+nFM6Cx7cwxhzrz5hZ2eryvwBt0q/L1LGx156UyYUx+cbtEeKl8g9fnBwSF5w==',
                t: 'MTY4MzAxNTI4NS4yMTMwMDA=',
                m: 'SGrVf5tNwHV7tAZ/i+xSzbm/NMe0OmJw/55lXhOczKo=',
                i1: 'qJOQqP8XmmwNMipLseYuHQ==',
                i2: 'Q7bbqGtZtXe+PFrPZbV8/Q==',
                zh: 'sjixqRSLa9EVXOTc7rZ+rm2ThxBuB3vWBNE2W8QzSOo=',
                uh: 'CY0Ky8FAVyI8TEHqZgOiLOnVpPC130qI4I6CoUal8BA=',
                hh: 'iL/xMm/kzXFdBWMAQTIQdH+4A0b81v+3SGvFhZixdAA=',
            }
        };
        var trkjs = document.createElement('img');
        trkjs.setAttribute('src', '/cdn-cgi/images/trace/managed/js/transparent.gif?ray=7c0ecffc8801ebbb');
        trkjs.setAttribute('alt', '');
        trkjs.setAttribute('style', 'display: none');
        document.body.appendChild(trkjs);
        var cpo = document.createElement('script');
        cpo.src = '/cdn-cgi/challenge-platform/h/g/orchestrate/managed/v1?ray=7c0ecffc8801ebbb';
        window._cf_chl_opt.cOgUHash = location.hash === '' && location.href.indexOf('#') !== -1 ? '#' : location.hash;
        window._cf_chl_opt.cOgUQuery = location.search === '' && location.href.slice(0, location.href.length - window._cf_chl_opt.cOgUHash.length).indexOf('?') !== -1 ? '?' : location.search;
        if (window.history && window.history.replaceState) {
            var ogU = location.pathname + window._cf_chl_opt.cOgUQuery + window._cf_chl_opt.cOgUHash;
            history.replaceState(null, null, "\/favicon-96x96.png?__cf_chl_rt_tk=ZG0OLbR.mKQoi5qOpVQGBc4_eScAhLCqPXRe829pYqE-1683015285-0-gaNycGzNCqU" + window._cf_chl_opt.cOgUHash);
            cpo.onload = function() {
                history.replaceState(null, null, ogU);
            };
        }
        document.getElementsByTagName('head')[0].appendChild(cpo);
    }());
</script>


</body>
</html>

Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until September 8th)

Reporter

Comment 2

•

2 years ago

We found two more results that have the same issue: politico and glassdoor.

Abhishek

Assignee

Comment 3

•

1 years ago

Working on resolving this one.

Abhishek

Assignee

Comment 4

•

1 years ago

A PR resolving this is in review.

Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until September 8th)

Reporter

Comment 5

•

1 years ago

I have verified this issue using the latest top_picks.json and here are the results:

"researchgate" and "glassdoor" no longer have an icon, so I am not sure if the issue is fixed for them.
For politico the issue seems to be fixed and the icon is correctly displayed.
I have found another result that has a broken favicon: xfinity. @Abhishek could you please take a look over this?

Flags: needinfo?(aaggarwal)

Abhishek

Assignee

Comment 6

•

1 years ago

Hey :cmuntean. Thanks for sharing the results. My comments are inlined:

(In reply to Cosmin Muntean [:cmuntean], Ecosystem QA from comment #5)

I have verified this issue using the latest top_picks.json and here are the results:

"researchgate" and "glassdoor" no longer have an icon, so I am not sure if the issue is fixed for them.

This is expected as per the latest changes. We have a minimum resolution criteria in place for favicons. Favicons for Researchgate don't satisfy it and Glassdoor don't have a favicon with correct mime type.

For politico the issue seems to be fixed and the icon is correctly displayed.

Great.

I have found another result that has a broken favicon: xfinity. @Abhishek could you please take a look over this?

Looking into this one.

Flags: needinfo?(aaggarwal)

Abhishek

Assignee

Comment 7

•

1 years ago

Submitted a PR to fix xfinity issue.

Abhishek

Assignee

Comment 8

•

1 years ago

PR is merged. We will land the new top picks file by tomorrow. After that this issue should be gone.

Abhishek

Assignee

Comment 9

•

1 year ago

PR to land new top picks file is in review. After merging this, this issue should be resolved.

Abhishek

Assignee

Comment 10

•

1 year ago

Hey folks. This issue is fixed now in the latest Nightly (version: 115.0a1 (2023-06-05) (64-bit)). Hence, closing it. Please feel free to reopen it if it is still reproducible.

Status: NEW → RESOLVED

Closed: 1 year ago

Resolution: --- → FIXED

Abhishek

Assignee

Updated

•

1 year ago

Status: RESOLVED → REOPENED

Resolution: FIXED → ---

Abhishek

Assignee

Updated

•

1 year ago

Status: REOPENED → RESOLVED

Closed: 1 year ago → 1 year ago

Resolution: --- → FIXED

Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until September 8th)

Reporter

Comment 11

•

1 year ago

I have verified this issue on the latest Nightly 116.0a1 (Build ID: 20230607214358), Beta 115.0b2 (Build ID: 20230606180112) and Firefox 114.0 Release (Build ID: 20230601151220) on Windows 10 x64, macOS 13.1 and Linux Mint.

The issue is no longer reproducible.
"researchgate" and "glassdoor" no longer have an icon, they have the default global favicon.
"xfinity" and "politico " have the correct icon displayed.

Status: RESOLVED → VERIFIED

status-firefox114: affected → verified

status-firefox115: --- → verified

status-firefox116: --- → verified

Abhishek

Assignee

Comment 12

•

1 year ago

Thanks Cosmin for verifying.

Abhishek

Assignee

Updated

•

1 year ago

Assignee: nobody → aaggarwal

Ryan VanderMeulen [:RyanVM]

Updated

•

1 year ago

status-firefox112: affected → wontfix

status-firefox113: affected → wontfix

Target Milestone: --- → 115 Branch

Bugzilla

The Top Picks result for Research Gate has a broken favicon

Categories

(Firefox :: Address Bar, defect)

Tracking

()

People

(Reporter: cmuntean, Assigned: aaggarwal)

References

(Blocks 1 open bug)

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Comment 2

Comment 3

Comment 4

Comment 5

Comment 6

Comment 7

Comment 8

Comment 9

Comment 10

Updated

Updated

Comment 11

Comment 12

Updated

Updated

Attachment

General

Description

File Name

Content Type