Define _USE_MATH_DEFINES and M_PI on both regular and mingw Windows builds
Categories
(Firefox Build System :: General: Unsupported Platforms, defect)
Tracking
(firefox115 fixed)
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Without _USE_MATH_DEFINES, Windows' math.h doesn't define M_PI.
_USE_MATH_DEFINES was defined for MSVC builds in bug 1228947, but it's also needed for mingw-clang builds on Try. (For some reason, mozilla-central's mingw-clang builds don't have this error, but Try builds do.)
obj-build/dist/include/mozilla/ServoStyleConstsInlines.h:396:32: error: use of undeclared identifier 'M_PI'
obj-build/dist/include/mozilla/StaticPrefList_apz.h:133:22: error: use of undeclared identifier 'M_PI'
obj-build/dist/include/mozilla/gfx/PathHelpers.h:139:33: error: use of undeclared identifier 'M_PI'
|
Assignee | |
Comment 1•2 years ago
|
||
Without _USE_MATH_DEFINES, Windows' math.h doesn't define M_PI. Since _USE_MATH_DEFINES is defined globally, redundant definitions of _USE_MATH_DEFINES in moz.build files can be removed.
obj-build/dist/include/mozilla/ServoStyleConstsInlines.h:396:32: error: use of undeclared identifier 'M_PI'
obj-build/dist/include/mozilla/StaticPrefList_apz.h:133:22: error: use of undeclared identifier 'M_PI'
obj-build/dist/include/mozilla/gfx/PathHelpers.h:139:33: error: use of undeclared identifier 'M_PI'
|
||
Updated•2 years ago
|
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Description
•