[Affected versions]:

• Firefox Nightly 115.0a1 (Build ID: 20230511213213)
• Firefox Beta 114.0b3 (Build ID: 20230511191645)

[Affected Platforms]:

• Windows 10 x64
• Linux Ubuntu 20.04 x64
• macOS 12.4

[Prerequisites]:

• Have a VPN client connected to a US server ( make sure the browser.search.region pref is set accordingly).
• Have the Firefox Nightly 115.0a1 or Beta 114.0b3 installed.
• Set the following prefs:
  browser.urlbar.weather.featureGate = true
  (Windows only) browser.urlbar.weather.ignoreVPN = true

[Steps to reproduce]:

1. Open the browser from the prerequisites.
2. Type the “weather” string in the Address Bar.
3. Click the Feedback button.
4. Click the “Show less frequently” option.
5. Repeat steps 3 and 4 for at least 2 more times.
6. Click the Feedback button.
7. Observe the menu options.

[Expected result]:

• The “Show less frequently” option is no longer available.

[Actual result]:

• The “Show less frequently” option remains displayed.

[Notes]:

• The “Show less frequently” option is removed if the Address Bar panel is closed and reopened after following the STR.
• The firefox-suggest-weather-command-show-less-frequently telemetry probe value is incremented each time the “Show less frequently” option is clicked - since the frequency option should be removed from the menu after 3 clicks, the behavior from the report could lead to gathering a number of unnecessary additional probes.
• Here is the screen recording of the issue.

https://hg.mozilla.org/mozilla-central/rev/4a281a783735

The patch landed in nightly and beta is affected.
:adw, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment on attachment 9333455 [details]
Bug 1832826 - Add a way to invalidate cached result menu commands and use it when the weather min keyword length cap is reached.

Beta/Release Uplift Approval Request

• User impact if declined: This bug is necessary for the Firefox Suggest weather suggestion feature we intend to ship in 114.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is small, only affects the weather suggestion which is not enabled by default, and has tests.
• String changes made/needed:
• Is Android affected?: No

We have verified this issue on the latest Firefox Nightly 115.0a1 (Build ID: 20230518213154) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• The “Show less frequently” option is no longer available when opening the Feedback menu button after reaching the frequency cap and the Address Bar results panel remains open.

Comment on attachment 9333455 [details]
Bug 1832826 - Add a way to invalidate cached result menu commands and use it when the weather min keyword length cap is reached.

Approved for 114.0b7.

https://hg.mozilla.org/releases/mozilla-beta/rev/3aa55413b9ab

We have verified this issue on the latest Firefox Beta 114.0b7 (Build ID: 20230521180321) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• The “Show less frequently” option is no longer available when opening the Feedback menu button after reaching the frequency cap and the Address Bar results panel remains open.