Closed Bug 1833262 Opened 2 years ago Closed 2 years ago

Ctrl+N for new contact in address book is enabled while editing existing or new contact and discards changes without asking

Categories

(Thunderbird :: Address Book, defect)

Thunderbird 102
defect

Tracking

(thunderbird114 verified)

RESOLVED FIXED
115 Branch
Tracking Status
thunderbird114 --- verified

People

(Reporter: thomas8, Assigned: aleca)

References

(Blocks 1 open bug)

Details

(Keywords: dataloss, ux-error-prevention)

Attachments

(1 file)

It's great that Ctrl+N works from pretty much everywhere in the AB to create a new contact. Also when editing a new or existing contact, whose changes will unfortunately get lost in the process without asking.

STR

  • Edit existing or new contact by changing/filling some data
  • Press Ctrl+N while in editing mode with unsaved changes

Actual

  • New contact is created without prompting to save changes, so changes are lost for good.

Expected

  • Should at least ask to save changes of unsaved contact before discarding them. User has certainly pressed Ctrl+N for a reason, so we could handle that situation gracefully. Should never discard data without asking.
  • Disable Ctrl+N when editing new/existing contact, consistent with the New Contact button which is also disabled. Probably no need to allow users to start a new contact without having saved the previous one.
Summary: Ctrl+N for new contact in address book while editing existing or new contact discards changes without asking → Ctrl+N for new contact in address book is enabled while editing existing or new contact and discards changes without asking
Assignee: nobody → alessandro
Status: NEW → ASSIGNED
Target Milestone: --- → 115 Branch

Pushed by solange@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/6306b0479375
Prevent creating new contact if address book is in edit mode. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Comment on attachment 9333819 [details]
Bug 1833262 - Prevent creating new contact if address book is in edit mode. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Thanks for this - it has bit me a few times

Attachment #9333819 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: