[Linux] The arrow icon indicating the collapsed menu from the Feedback menu button is barely visible with the Alpenglow Theme enabled
Categories
(Firefox :: Address Bar, defect, P3)
Tracking
()
People
(Reporter: cfat, Unassigned)
References
Details
Attachments
(2 files, 1 obsolete file)
[Affected versions]:
- Firefox Nightly 115.0a1 (Build ID: 20230516042430)
- Firefox Beta 114.0b4 (Build ID: 20230514175823)
[Affected Platforms]:
- macOS 12.6.1
- Ubuntu 20.04 x64
[Prerequisites]:
- Have a VPN client connected to a US server ( make sure the
browser.search.region
pref is set accordingly). - Have the Firefox Nightly 115.0a1 or Beta 114.0b4 installed.
- Set the following pref:
browser.urlbar.weather.featureGate
=true
[Steps to reproduce]:
- Open the browser from the prerequisites.
- Type the “weather” string in the Address Bar.
- Hover the weather result and click the “Feedback” menu button.
- Observe the arrow icon that indicates the collapsed menu.
[Expected result]:
- The arrow is easily visible.
[Actual result]:
- The arrow is hardly visible.
[Notes]:
- The issue is also reproducible for the separator line between the “Don’t show this” and “Learn more about Firefox Suggest” options.
- The issue is also reproducible using the Firefox Alpenglow Theme.
- On Ubuntu, the issue is only reproducible with the Firefox Alpenglow Theme.
- Attached is a screenshot of the issue.
Comment 1•1 year ago
|
||
Bug 1831760 fixes this on Mac by using a native menu. In the meantime and for Linux, I'll see if it's possible to give the arrow and separator a better color in CSS.
Comment 2•1 year ago
|
||
Bug 1831760 landed so this should be fixed on Mac on 115. I'm not planning on uplifting it to 114 because it's too risky IMO.
I looked into a short-term fix on Mac for 114 and it's tricky because the arrow is drawn using a native API with a native arrow image, even though the menu itself isn't native, and it doesn't seem possible to give it a different color. I haven't looked into Linux yet. I'm still investigating and I'll ask around but we may have to live with this bug on 114.
Comment 3•1 year ago
|
||
Comment 4•1 year ago
|
||
Comment on attachment 9334958 [details]
Bug 1833390 - Improve the menuarrow and menu separator colors in non-native Mac menus in the dark appearance.
Revision D178514 was moved to bug 1834135. Setting attachment 9334958 [details] to obsolete.
Comment 5•1 year ago
|
||
(In reply to Drew Willcoxon :adw from comment #2)
Bug 1831760 landed so this should be fixed on Mac on 115. I'm not planning on uplifting it to 114 because it's too risky IMO.
Bug 1834135 is the Mac fix I want to uplift to 114.
Comment 6•1 year ago
|
||
This is fixed on Mac on 114 (non-native menu) and 115 (native menu), so this is Linux only now. Updating the bug accordingly.
Comment 7•1 year ago
|
||
Here's an Ubuntu Alpenglow png that's a little clearer than the jpeg in comment 0. It's not great but it could be worse. Neither Firefox's dark theme nor Ubuntu's dark theme is affected, just Alpenglow and possibly other similar themes.
Updated•1 year ago
|
Comment 8•1 year ago
|
||
I'm not currently working on this. Now that this happens only on Linux with Alpenglow, I'll also downgrade the priority and severity.
Description
•