(not reading, please use seth@sspitzer.org instead) Reporter
	Description • 22 years ago

bryner tells me:

sometimes when you delete a message, the focus gets lost instead of going to the
next message

i see it occasionally but i'm not sure what triggers it

I think I've seen it too, but haven't been able to reproduce it.

could be an edge case in HandleDeleteOrMoveMsgCompleted(), most of these types
of problems in that code, or the code that calls it.

	David :Bienvenu Assignee
	Comment 1 • 22 years ago

for me what causes it is getting a message filtered into the folder right when
the delete is going on.

	jquinn
	Comment 2 • 22 years ago

I was just seeing this repeatably in 1.2.1 (move to trash, empty trash on exit
options set). I came to mark this bug here and now it's working so I guess this
is still intermittent.

	Wayne Mery (:wsmwk)
	Comment 3 • 19 years ago

WFM - never fails for me in SM after multiple attempts

however, problem is very evident in TB - noted in Bug 268098 

	Pierre
	Comment 4 • 19 years ago

I can reproduce this with Seamonkey all the time.
I never had this problem with Mozilla 1.7.12.
Seems the same that https://bugzilla.mozilla.org/show_bug.cgi?id=268098 for TB

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050910 SeaMonkey/1.0a

	Wayne Mery (:wsmwk)
	Comment 5 • 19 years ago

(In reply to comment #4)
> I can reproduce this with Seamonkey all the time.
> I never had this problem with Mozilla 1.7.12.
> Seems the same that https://bugzilla.mozilla.org/show_bug.cgi?id=268098 for TB
> 
> Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050910 SeaMonkey/1.0a

Pierre can you reproduce this with trunk build?  http://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/latest-trunk/

Also, do your steps to reproduce match the information in the Bug 268098 comment 3 and bug 264951. If not, please provide circumstances and details of reproducing the error.

	David :Bienvenu Assignee
	Comment 6 • 19 years ago

I see this now (in TB, but I bet it's in SM as well) when I delete a message before it's finished loading, e.g., a giant message.

	David :Bienvenu Assignee
	Comment 7 • 19 years ago

In my reproducible case, I press delete before the message finishes loading. Then we get the OnMsgLoaded notification, which sets gNextMessageViewIndexAfterDelete to -2, after the start of the delete code went to all that trouble to set it to the next message to load. Then, when the delete finishes, we get HandleDeleteOrMoveMsgCompleted, which notices that gNextMessageViewIndexAfterDelete is -2, and doesn't select the message it should...perhaps we can check for this case somehow in OnMsgLoaded

	David :Bienvenu Assignee
	Comment 8 • 19 years ago

remember the selected index when delete is pressed. If when we finish loading a message, and the selected index has changed, then set gNextMessageViewIndexAfterDelete to -2. This seems to work, at least for the problem scenario. When I select a message while delete is going on, it tends to be by the number of messages getting deleted, but that was the case w/o my patch as well.

	David :Bienvenu Assignee
	Comment 9 • 19 years ago

fixed on trunk. 

	Scott MacGregor
	Comment 10 • 19 years ago

This patch causes a JS error in the stand alone message window when you double click a message from the 3-pane because there is no ThreadTree in OnMsgLoaded in mailWindowOverlay.js.

This bug keeps falling off the tracking radar for me, adjusting.

	Scott MacGregor
	Comment 11 • 19 years ago

this is now on the branch (along with 326846).

This kind of bug is annoying enough where we might want to think about it for 1.8.0.2.

Nominating so I remember to come back and take a look at this after its baked on the 1.8 branch some more. 

	Scott MacGregor
	Comment 12 • 19 years ago

Comment on attachment 208341 [details] [diff] [review]
proposed fix

we decided to take this for 1.8.0.2.

	David :Bienvenu Assignee
	Comment 13 • 19 years ago

fix for this and regression bug 326846 checked into 1.8.0.2 branch

	N. Becker
	Comment 14 • 19 years ago

please make sure this gets checked into the seamonkey branch, as its not in the 1.0 release.  thanks!  -a newbie

	Marcia Knous [:marcia]
	Comment 15 • 19 years ago

I tried a few variations of this in trying to verify it on the 1.8.0 branch and did not see any problems. Adding Tracy to the bug so he can try it out as well.

	Mike Cowperthwaite
	Comment 16 • 19 years ago

*** Bug 261154 has been marked as a duplicate of this bug. ***

	Mike Cowperthwaite
	Comment 17 • 19 years ago

*** Bug 268098 has been marked as a duplicate of this bug. ***

	Mike Cowperthwaite
	Comment 18 • 19 years ago

*** Bug 319362 has been marked as a duplicate of this bug. ***

	Tracy Walker [:tracy]
	Comment 19 • 19 years ago

I haven't seen this in dogfooding for over a week. 

	Bob Clary [:bc] (inactive)
	Comment 20 • 19 years ago

I could temporarily reproduce the bug in tbird1502/winxp/20060308 when deleting emails from my junk folder, but afterwards I could not reproduce it. There may be a circumstance where the bug still appears, but I don't know what. leaving verified.