Closed
Bug 1834002
Opened 1 year ago
Closed 1 year ago
Avoid InvalidateFrameSubtree in HTMLInputElement::SetCheckedInternal
Categories
(Core :: DOM: Core & HTML, task)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
119 Branch
| Tracking | Status | |
|---|---|---|
| firefox119 | --- | fixed |
People
(Reporter: mstange, Assigned: smaug, NeedInfo)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The call to InvalidateFrameSubtree shows up in TodoMVC-Svelte profiles under inputElement.click(): https://share.firefox.dev/3BIh6uF
It's not much, but any amount we can shave off from this profile is valuable.
void HTMLInputElement::SetCheckedInternal(bool aChecked, bool aNotify) {
// Set the value
mChecked = aChecked;
// Notify the frame
if (mType == FormControlType::InputCheckbox ||
mType == FormControlType::InputRadio) {
nsIFrame* frame = GetPrimaryFrame();
if (frame) {
frame->InvalidateFrameSubtree();
}
}
Can this be replaced with SchedulePaint() / DLBI?
Flags: needinfo?(tnikkel)
|
||
Updated•1 year ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-383
|
Assignee | |
Comment 1•1 year ago
|
||
Or the UpdateState call below should be enough, no?
|
|
Assignee | |
Updated•1 year ago
|
Component: Web Painting → DOM: Core & HTML
|
|
Assignee | |
Comment 2•1 year ago
|
||
|
||
Updated•1 year ago
|
Attachment #9350823 -
Attachment description: WIP: Bug 1834002 - Avoid InvalidateFrameSubtree in HTMLInputElement::SetCheckedInternal, r=emilio → Bug 1834002 - Avoid InvalidateFrameSubtree in HTMLInputElement::SetCheckedInternal, r=emilio
|
|
||
Updated•1 year ago
|
Assignee: nobody → smaug
Status: NEW → ASSIGNED
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bfc7a975567
Avoid InvalidateFrameSubtree in HTMLInputElement::SetCheckedInternal, r=emilio
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox119:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•