The text elements from the weather result are shifted under the current temperature box when resizing the browser
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox113 | --- | unaffected |
firefox114 | --- | unaffected |
firefox115 | --- | verified |
firefox116 | --- | verified |
People
(Reporter: cfat, Assigned: daleharvey)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [snt][snt-scrubbed])
Attachments
(2 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details |
[Affected versions]:
- Firefox Nightly 115.0a1 (Build ID: 20230518213154)
[Affected Platforms]:
- Windows 10 x64
- macOS 12.6.1
- Ubuntu 20.04 x64
[Prerequisites]:
- Have a VPN client connected to a US server ( make sure the
browser.search.region
pref is set accordingly). - Have the Firefox Nightly 115.0a1 installed.
- Set the following prefs:
browser.urlbar.weather.featureGate
=true
- (Windows only)
browser.urlbar.weather.ignoreVPN
=true
[Steps to reproduce]:
- Open the browser from the prerequisites.
- Type the “weather” string in the Address Bar.
- Resize the width of the browser to minimum.
- Observe the weather result.
[Expected result]:
- The weather result text is correctly wrapped and displays a fading effect at its end.
[Actual result]:
- The text elements are shifted under the temperature box.
[Notes]:
-
Based on mozregression, it seems that the bug that caused this regression is Bug 1826447.
-
12:23.31 INFO: Last good revision: 27a022ccd011a0d52e64fe813bbc54d17c869597
-
12:23.32 INFO: First bad revision: cdcf9d894d0573d249e80dbf465226cd134caa68
-
12:23.32 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=27a022ccd011a0d52e64fe813bbc54d17c869597&tochange=cdcf9d894d0573d249e80dbf465226cd134caa68 -
Here is a screen recording of the issue.
Reporter | ||
Updated•1 years ago
|
Comment 1•1 years ago
|
||
Set release status flags based on info from the regressing bug 1826447
:daleharvey, since you are the author of the regressor, bug 1826447, could you take a look?
For more information, please visit BugBot documentation.
Comment 3•1 years ago
|
||
:daleharvey FYI soft code freeze is this week, and 115 merge day is on 2023-06-05.
There is no priority set, do you expect to have a fix before merge day?
Updated•1 years ago
|
Updated•1 years ago
|
Assignee | ||
Comment 4•1 years ago
|
||
Yeh I will make sure to have a patch in before the 5th
Updated•1 year ago
|
Assignee | ||
Comment 5•1 year ago
|
||
Comment 7•1 year ago
|
||
Set release status flags based on info from the regressing bug 1826447
Comment 8•1 year ago
|
||
bugherder |
Comment 9•1 year ago
|
||
The patch landed in nightly and beta is affected.
:daleharvey, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox115
towontfix
.
For more information, please visit BugBot documentation.
Reporter | ||
Comment 10•1 year ago
|
||
I verified this issue using the latest Nightly 116.0a1 (Build ID: 20230607033033) on Windows 10 x64, Linux Ubuntu 20.04 x64, and macOS 12.6.1.
- The Weather result text is no longer shifted under the temperature box.
- The Weather result text correctly wraps on the right side of the temperature box, displaying a fade effect at its end when the browser width is minimized.
Assignee | ||
Comment 11•1 year ago
|
||
Comment on attachment 9337563 [details]
Bug 1834060 - Ensure urlbar weather view does not wrap on small widths. r=dao
Beta/Release Uplift Approval Request
- User impact if declined: Weather experiment users will have broken experience
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Minor CSS change that has been verified
- String changes made/needed:
- Is Android affected?: No
Comment 12•1 year ago
|
||
Comment on attachment 9337563 [details]
Bug 1834060 - Ensure urlbar weather view does not wrap on small widths. r=dao
Approved for 115.0b3.
Comment 13•1 year ago
|
||
bugherder uplift |
Reporter | ||
Comment 14•1 year ago
|
||
I verified this issue using the latest Beta 115.0b3 (Build ID: 20230608214116) on Windows 10 x64, Linux Ubuntu 20.04 x64, and macOS 12.6.1.
- The Weather result text is no longer shifted under the temperature box.
- The Weather result text correctly wraps on the right side of the temperature box, displaying a fade effect at its end when the browser width is minimized.
Description
•