Closed
Bug 1834226
Opened 1 year ago
Closed 1 year ago
Untangle HandleEventInternal listener checks
Categories
(Core :: DOM: Events, task)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
115 Branch
Tracking | Status | |
---|---|---|
firefox115 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
At the moment, some checks are in ListenerCanHandle, some are in IsListening, and the event group check is done twice. I have a patch to clean this up a bit.
Assignee | ||
Comment 1•1 year ago
|
||
This makes the loop a bit easier to read. It is now clear which conditions
are checked where, and the use of "continue" avoids some indentation.
This is also getting rid of the lambda in ListenerCanHandle.
All checks are performed in the same order as before.
The only change is the removal of a main thread assert when we check
the event message in the spot where the message is not eUnidentifiedEvent.
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/ad6fc686c6a8 Untangle listener checks in HandleEventInternal. r=smaug
Comment 3•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox115:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
Updated•1 year ago
|
Whiteboard: [sp3]
Updated•1 year ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-395
You need to log in
before you can comment on or make changes to this bug.
Description
•