Closed Bug 1834892 Opened 2 years ago Closed 2 years ago

Allow time values without a leading `0` in SVG/SMIL time attributes (begin/dur/end)

Categories

(Core :: SVG, defect)

defect

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: dholbert, Assigned: longsonr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Spinning this off from bug 1806276 comment 19.

STR:

  1. Load this animated SVG:
    https://bug1806276.bmoattachments.org/attachment.cgi?id=9326270

EXPECTED RESULTS: Smooth animation
ACTUAL RESULTS: Weird-looking jumpy animation.

longsonr diagnosed this as us (correctly) rejecting some values in the begin attribute for some animations in this SVG, because they're fracitonal and they lack a leading 0.

Chromium and WebKit don't require a leading 0 for fractional time values in SVG dur, begin, etc. longsonr filed a spec-issue 5 years ago to propose that we update the spec to allow such values, in https://github.com/w3c/svgwg/issues/394 . It seems like nobody's opposed there, though the spec edit hasn't happened yet (there are some grammar subteties to sort out).

I think we could just go ahead and implement a fix of some sort on our end, though, to avoid being uniquely hit by rendering issues where we're technically correct but uniquely-affected like in bug 1806276 comment 19.

Assignee: nobody → longsonr
Status: NEW → ASSIGNED
Attachment #9335758 - Attachment description: Bug 1834892 - permit SMIL timecount values to begin with . r=dholbert → Bug 1834892 - permit fractional SMIL timecount values to omit leading 0 r=dholbert
Blocks: 1806276
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/autoland/rev/fef0d9458939 permit fractional SMIL timecount values to omit leading 0 r=dholbert
Regressions: 1834980
Flags: needinfo?(longsonr)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 115 Branch → ---
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5335cd5396a1 permit fractional SMIL timecount values to omit leading 0 r=dholbert
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: