Closed Bug 1834946 Opened 1 years ago Closed 1 years ago

compatibility spec's compatibilityissues should have a nullable url property

Categories

(DevTools :: Inspector: Compatibility, defect)

defect

Tracking

(firefox115 fixed)

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

Patch for Bug 1833617 revealed an issue: some properties (e.g. overflow-clip-box) are not referenced on MDN, so url is undefined for them, which makes the call to getCSSDeclarationBlockIssues/getNodeCssIssues fail (response can't be written)

The url should be nullable, and in the panel (and tooltip), the property shouldn't be rendered as a link when there's no url attached.

Blocks: 1659498
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00bc160667b0 [devtools] MDN compat data url is nullable. r=jdescottes,devtools-backward-compat-reviewers,devtools-reviewers.

Backed out for causing compatibility related failures.

Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/33f1e388e93e [devtools] MDN compat data url is nullable. r=jdescottes,devtools-backward-compat-reviewers,devtools-reviewers.

fixed the test and pushed again

Flags: needinfo?(nchevobbe)
Status: ASSIGNED → RESOLVED
Closed: 1 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: