Closed Bug 1835008 Opened 1 years ago Closed 1 years ago

Changing keyword capitalization causes firefox add-on suggestion to NOT be displayed

Categories

(Firefox :: Address Bar, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox115 --- verified

People

(Reporter: cbaica, Unassigned)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Attached video capitalization of keywords bug (deleted) —

Found in

  • Fx 115.0a1

Affected versions

  • Fx115.0a1

Affected platforms

  • Windows 10
  • macOS
  • Ubuntu 20

Preconditions
browser.urlbar.addons.featureGate set to true
browser.urlbar.suggest.addons set to true
browser.urlbar.quicksuggest.enabled set to true
browser.urlbar.suggest.quicksuggest.nonsponsored set to true
browser.urlbar.quicksuggest.dataCollection.enabled set to true
browser.urlbar.merino.enabled set to true
browser.urlbar.merino.providers set to amo
browser.urlbar.bestMatch.enabled set to true

Steps to reproduce

  1. Launch Firefox.
  2. In the URL bar, write 'ublock Origin'.

Expected result

  • The Firefox add-on suggestion for Ublock is displayed in the top pick section.

Actual result

  • NO add-on suggestion is triggered.

Regression range

  • Not a regression.

Additional notes

  • Add-on suggestions are only displayed if they keywords don't contain any capital letters.
Assignee: nobody → daisuke
Status: NEW → ASSIGNED

Thank you very much for the report. I also could reproduce it.

I investigated this, it seems that the issue might be caused by Merino implementation for amo.
Even if I input nike and Nike and any query including upper cases on the urlbar, I could see the sponsored suggestion from the queries, but not amo. Just to be safe, I took a look at the suggestions data in UrlbarProviderQuickSuggest as well, but there were no suggestions for amo if the query includes upper case char.

I have seen the Merino code, it seems that amo provider does not normalize the query, so, we should do it as the same as other providers?
https://github.com/mozilla-services/merino-py/blob/ab2958ea9be79e5a386db500512b37680e393207/merino/providers/adm/provider.py#L129-L131

Flags: needinfo?(adw)
Status: ASSIGNED → NEW
Assignee: daisuke → nobody
Has STR: --- → yes

Yes that looks right to me Daisuke. I've asked Michelle about this too on Slack. I think the amo provider should normalize the query string like the adm provider does.

Flags: needinfo?(adw)

This has been fixed on Merino: https://github.com/mozilla-services/merino-py/pull/311

It can be verified using the preconditions in comment 0 and also setting browser.urlbar.quicksuggest.remoteSettings.enabled to false to turn off remote settings suggestions.

Addon suggestions from remote settings don't have this problem, and that can be verified by setting browser.urlbar.quicksuggest.remoteSettings.enabled back to true and browser.urlbar.quicksuggest.dataCollection.enabled to false to disable Merino.

Status: NEW → RESOLVED
Closed: 1 years ago
Resolution: --- → FIXED

The issue is verified fixed using the latest Fx 115.0b3 on Windows 10 and Ubuntu 20. The add-on suggestions are correctly triggered regardless of capitalization, from merino as well as RS.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: