Closed Bug 1835026 Opened 2 years ago Closed 1 years ago

Bug 1834664 has regressed bug 507541: Selected text from unrelated message is quoted when right-click replying to another message, cunningly with correct attribution line

Categories

(Thunderbird :: Folder and Message Lists, defect)

Thunderbird 115
defect

Tracking

(Not tracked)

RESOLVED FIXED
115 Branch

People

(Reporter: klaus.kueppers, Assigned: darktrojan)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [Supernova3p])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1834664 +++

Selected text from unrelated message is quoted when right-click replying to another message, cunningly with correct attribution line.

See bug 1818683 comment #7 for prior discussion on this.

Blocks: sn-msglist
Keywords: regression
Regressed by: 1834664
Whiteboard: [Supernova3p]

I also noticed that when you have two messages with a bad charset, repairing the encoding on the first message also forces a repair on the second message when replying to it via right-click. So the autodetectCharset setting is carried over from the viewed message to the message being replied to. Not necessarily strictly harmful, but also not correct in case the repair of the second message is undesired or faulty.

Assignee: nobody → geoff
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

The issue with the charset detection could be fixed at the same location?

let selection;
if (!mailContextMenu.selectionIsOverridden) {
  selection = messagePaneBrowser?.contentWindow?.getSelection();
} else {
  // If overridden, don't force charset detection.
  autodetectCharset = false;
}

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/cf9bc3c16765
Quote the right message when replying from the context menu. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/ba950e232ed4 follow-up - Try to fix a flaky test. rs=me
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: