Closed Bug 1835053 (syn-2) Opened 1 year ago Closed 1 year ago

[tracking] Transition to syn 2

Categories

(Firefox Build System :: General, task, P3)

task

Tracking

(firefox118 fixed)

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: janerik, Assigned: glandium)

References

Details

(Keywords: meta)

Attachments

(1 file)

syn is a parser for Rust source code, most frequently used in procedural macros.
It got a v2 release some time ago and more and more other crates are switching over to that.
UniFFI, our Rust bindings generator, also has plans to upgrade.

Right now we only have syn v1 in-tree.
As we currently disallow duplicate crates it would be rejected unless we explicitly allow it (by modifying TOLERATED_DUPES).

Are we okay with pulling in syn v2?
(Actually pulling it in will happen later, only once UniFFI actually merges said PR, does a release and we upgrade a-s and Glean to that)

This sounds like a glandium question...

Assignee: tom → nobody
Component: Mach Vendor & Updatebot → Toolchains
Flags: needinfo?(mh+mozilla)
Product: Developer Infrastructure → Firefox Build System

Let me give you a definite answer to this next week. I'm evaluating the situation.

Ok. Let's do this, but please update the askama dependency for it to pick syn2 too. I'll start by adding syn2 in tree alongside an upgrade of serde after the merge. I have local patches that get me to this point:

$ grep -c "syn 1" Cargo.lock 
15
$ grep -c "syn 2" Cargo.lock 
30

(and that's without uniffi/askama, which would make it 11/34)

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(mh+mozilla)
Resolution: --- → FIXED

Let's track progress with this bug, actually.

Status: RESOLVED → REOPENED
Component: Toolchains → General
Depends on: 1836219
Resolution: FIXED → ---
Summary: Decide whether to allow Rust crate syn v2 in tree as duplicate → [tracking] Transition to syn 2
Alias: syn-2
Depends on: 1836229
Depends on: 1836230
Depends on: 1836232
Depends on: 1836234
Depends on: 1836236
Depends on: 1836415
Depends on: 1836419
Depends on: 1836420
Severity: -- → S3
Priority: -- → P3
Depends on: 1836869
Depends on: 1836878
Depends on: 1837098
Depends on: 1743983
Depends on: 1839799
Depends on: 1840021
Depends on: 1840022
Depends on: 1840044
Depends on: 1841150
Depends on: 1841878
No longer depends on: 1743983
Depends on: 1846405
Depends on: 1846406

It's the last crate with a remaining dependency on syn v1. The
transition is over.

Assignee: nobody → mh+mozilla
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/20af9af06587 Remove syn v1 from the workspace-hack. r=firefox-build-system-reviewers,ahochheiden
Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: