Combine requested heap check with check for nursery allocation allowed
Categories
(Core :: JavaScript: GC, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox115 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
(Whiteboard: [sp3])
Attachments
(3 files)
Currently we test whether nursery allocation is allowed for a zone and trace kind, and separately check the requested heap.
We can combine these checks into one by adding a per-zone per-trace kind state which represents whether nursery allocation is allowed for that trace kind in terms of a minimum allowed InitialHeap (i.e. DefaultHeap => nursery allocation allowed, TenuredHeap => not allowed).
We can compare this to the requested InitialHeap value and if the requested value is less than or equal to the minimum then allocate in the nursery. This relies on the value TenuredHeap being greater than DefaultHeap.
Assignee | ||
Comment 1•1 year ago
|
||
This removes some vestiges of nursery canaries that were missed from the
previous bug. Also moves some uncommonly moved method definitions out of line.
Assignee | ||
Comment 2•1 year ago
|
||
Add min heap to tenured state the zone and use it to combine the heap checks.
I'm open to a better name for this.
Depends on D179470
Assignee | ||
Comment 3•1 year ago
|
||
Renames InitialHeap because it's not just used for the initial heap now. Also
makes it into an enum class.
This patch is almost entirely search and replace.
Depends on D179471
Comment 5•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0a5748964ba3
https://hg.mozilla.org/mozilla-central/rev/e386c59f1d6e
https://hg.mozilla.org/mozilla-central/rev/8f9d8bdcc4cc
https://hg.mozilla.org/mozilla-central/rev/4f8fb0745e75
Updated•1 year ago
|
Updated•1 year ago
|
Description
•