Closed Bug 1836875 Opened 1 year ago Closed 1 year ago

Bump subsystem version to 10.0 to block Firefox from running on Windows 7/8/8.1

Categories

(Firefox Build System :: General, defect, P3)

Product:
Firefox Build System
Component:
General
Type:
defect

Tracking

(firefox117 fixed)

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: emk, Assigned: emk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Bug 1836875 - Bump subsystem version to 10.0 to block Firefox from running on Windows 7/8/8.1. r?#build
(deleted), text/x-phabricator-request
Details
No description provided.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED

please don't land these changes yet.

Comment on attachment 9337579 [details]
Bug 1836875 - Prevent installers from installing Firefox 116+ on Windows 7/8/8.1. r?mhowell

Revision D180029 was moved to bug 1836874. Setting attachment 9337579 [details] to obsolete.

Attachment #9337579 - Attachment is obsolete: true

(In reply to Sylvestre Ledru [:Sylvestre] from comment #3)

please don't land these changes yet.

Sure. I can't land this at least until bug 1835971 and bug 1836274 are fixed. Please file bugs and block this if I overlooked other blocking factors.

Depends on: 1837000
Severity: -- → S3
Priority: -- → P3
Attachment #9337818 - Attachment description: Bug 1836875 - Temporarily lower the subsystem version for SpiderMonkey. r?#build → Bug 1836875 - Temporarily lower the subsystem version for SpiderMonkey and PGO. r?#build

Can I land this patch now?

Flags: needinfo?(sledru)

yes please, sorry :)

Flags: needinfo?(sledru)
Attachment #9337567 - Attachment description: Bug 1836875 - Bump subsystem version to 10.0 to block Firefox from running on Windows 7/8/8.1. r?#build → Bug 1836875 - Bump subsystem version to 8.1 to block Firefox from running on Windows 7/8. r?#build
Attachment #9337818 - Attachment is obsolete: true
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/autoland/rev/706fc856ba78 Bump subsystem version to 8.1 to block Firefox from running on Windows 7/8. r=firefox-build-system-reviewers,glandium

Backed out because it will break win PGO and SM jobs(as requested by Ryan on slack)

Flags: needinfo?(VYV03354)

Why do you think this patch breaks PGO and SM jobs? I folded D180180 so that the patch does not break PGO and SM jobs, and actually this patch did not break SM jobs:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=706fc856ba786da7b1796a8daa3a9e1b24fe5eae&job_type_name=sm&platform=windows

Flags: needinfo?(VYV03354) → needinfo?(ryanvm)
No longer depends on: 1837000
Summary: Bump subsystem version to 10.0 to block Firefox from running on Windows 7/8/8.1 → Bump subsystem version to 6.03 to block Firefox from running on Windows 7/8

We are in the process of figuring out what the migration to Win2022 looks like. To avoid confusion, we should hold off on this for now. If that looks be to longer-term than we're comfortable with, we can revisit. But like the other bug, this is very-much on our radar and we will move forward with landing when the time is right.

Flags: needinfo?(ryanvm)
Attachment #9337567 - Attachment description: Bug 1836875 - Bump subsystem version to 8.1 to block Firefox from running on Windows 7/8. r?#build → Bug 1836875 - Bump subsystem version to 10.0 to block Firefox from running on Windows 7/8/8.1. r?#build
Summary: Bump subsystem version to 6.03 to block Firefox from running on Windows 7/8 → Bump subsystem version to 10.0 to block Firefox from running on Windows 7/8/8.1
Pushed by rvandermeulen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/51824a802d0d Bump subsystem version to 10.0 to block Firefox from running on Windows 7/8/8.1. r=firefox-build-system-reviewers,glandium

https://hg.mozilla.org/mozilla-central/rev/51824a802d0d

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: