Replace [first-visible-unpinned-tab] selector with :nth-child and get rid of _setPositionalAttributes
Categories
(Firefox :: Tabbed Browser, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 3 open bugs)
Details
(Keywords: perf)
Attachments
(2 files)
.tabbrowser-tab:nth-child(1 of :not([pinned], [hidden])) should work instead of .tabbrowser-tab[first-visible-unpinned-tab], allowing us to finally get rid of _setPositionalAttributes.
|
Assignee | |
Comment 2•1 years ago
|
||
|
||
Updated•1 years ago
|
|
||
Comment 3•1 years ago
|
||
Do we need that first-visible-unpinned-tab at all? It's only used to add an extra hard-coded margin between the pinned and unpinned tabs, can't we just account for that extra space in _positionPinnedTabs?
If not, we should probably remove the pref for :nth-child(... of), if the front-end is going to start relying on it.
|
|
Assignee | |
Comment 4•1 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)
Do we need that
first-visible-unpinned-tabat all? It's only used to add an extra hard-coded margin between the pinned and unpinned tabs, can't we just account for that extra space in_positionPinnedTabs?
_positionPinnedTabs only does its thing when tabs overflow, otherwise pinned tabs are static in the tab strip like normal tabs, and that's when we want this gap.
If not, we should probably remove the pref for
:nth-child(... of), if the front-end is going to start relying on it.
To be clear, it's enabled by default, right? So yeah, removing the pref might be a good idea, although in this particular case things won't fall apart with the pref disabled, the gap just won't be there.
|
|
||
Comment 6•1 years ago
|
||
We ship this, and the front-end uses it by default, so remove the pref.
|
|
Assignee | |
Updated•1 years ago
|
|
|
Assignee | |
Updated•1 years ago
|
|
||
Comment 9•1 years ago
|
||
| bugherder | ||
|
||
Comment 10•1 years ago
|
||
| bugherder | ||
Description
•