This update covers 21 commits.. Here are the overall diff statistics, and then the commit information.

toolkit/components/pdfjs/content/build/pdf.js | 1872 ++--
toolkit/components/pdfjs/content/build/pdf.scripting.js | 383 +-
toolkit/components/pdfjs/content/build/pdf.worker.js | 4833 +++++++------
toolkit/components/pdfjs/content/web/viewer-geckoview.js | 68 +-
toolkit/components/pdfjs/content/web/viewer.js | 68 +-
toolkit/components/pdfjs/moz.yaml | 4 +-
6 files changed, 3737 insertions(+), 3491 deletions(-)

3d98fb3c0b82040bbb3dae05c8fa43b8d866183d by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/3d98fb3c0b82040bbb3dae05c8fa43b8d866183d
Authored: 2023-06-06 10:51:49 +0200
Committed: 2023-06-06 11:40:54 +0200

[Editor] Commit the text when the user hits ctrl+s (bug 1831574)

Files Modified:

• src/display/editor/freetext.js
• src/display/editor/tools.js

2f0bb9dc2feb0464affadba5bfb9d929ace7cad9 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/2f0bb9dc2feb0464affadba5bfb9d929ace7cad9
Authored: 2023-06-05 21:00:56 +0200
Committed: 2023-06-05 21:31:19 +0200

[Editor] Allow to undo/redo committed text modifications for FreeText

Files Modified:

• src/display/editor/freetext.js
• test/integration/freetext_editor_spec.js

ba8c996623c66703d5b2b97cfa3850486a40d057 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/ba8c996623c66703d5b2b97cfa3850486a40d057
Authored: 2023-06-05 12:15:41 +0200
Committed: 2023-06-05 17:15:17 +0200

[Editor] Guess font size and color from the AS of FreeText annotations

Files Modified:

• src/core/annotation.js
• src/core/default_appearance.js
• test/unit/default_appearance_spec.js

9f861c39f4c902d0a6a72fd18859d9fdd3778675 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/9f861c39f4c902d0a6a72fd18859d9fdd3778675
Authored: 2023-06-05 11:32:44 +0200
Committed: 2023-06-05 14:05:52 +0200

[Editor] Connect then annotation layer and the editor one

Files Modified:

• src/display/annotation_layer.js
• src/display/editor/annotation_editor_layer.js
• src/display/editor/editor.js
• src/display/editor/freetext.js
• src/display/editor/ink.js
• web/annotation_editor_layer_builder.js
• web/pdf_page_view.js

046b9050ddb53df65b2f420f02ce632b7606e97a by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/046b9050ddb53df65b2f420f02ce632b7606e97a
Authored: 2023-06-04 13:51:24 +0200
Committed: 2023-06-04 13:51:24 +0200

Remove unused variables in InkAnnotation.createNewAppearanceStream (issue 16518, PR 16494 follow-up)

Files Modified:

• src/core/annotation.js

a9093a7f4d3fde209a2a160a6d6fad171f598084 by Tim van der Meij

https://github.com/mozilla/pdf.js/commit/a9093a7f4d3fde209a2a160a6d6fad171f598084
Authored: 2023-06-04 13:37:26 +0200
Committed: 2023-06-04 13:49:44 +0200

Improve Puppeteer's trimCache API usage

The original trimCache functionality was intended to be exposed on the
top-level puppeteer module, but due to a bug in Puppeteer this didn't
work correctly and we had to call trimCache on the default Puppeteer
node instance instead, which was fortunately exposed. However, since
this didn't feel like intended API usage, this bug was reported and is
now fixed in Puppeteer 20.5.0, so this commits updates Puppeteer to that
version so we can use the intended API.

The full history of this issue can be found at
https://github.com/puppeteer/puppeteer/issues/10174.

Files Modified:

• package-lock.json
• package.json
• test/test.js

cf3a35e9daaa5a456109943b4cfc87c0471118b8 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/cf3a35e9daaa5a456109943b4cfc87c0471118b8
Authored: 2023-06-02 14:41:27 +0200
Committed: 2023-06-04 13:44:15 +0200

Enable the import/no-cycle ESLint plugin rule

Having cyclical imports is obviously not a good idea, and this ESLint plugin rule can help detect those; please see https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-cycle.md

Files Added:

• src/core/xfa/symbol_utils.js
• src/scripting_api/app_utils.js

Files Modified:

• .eslintrc
• src/core/xfa/bind.js
• src/core/xfa/builder.js
• src/core/xfa/config.js
• src/core/xfa/data.js
• src/core/xfa/datasets.js
• src/core/xfa/factory.js
• src/core/xfa/fonts.js
• src/core/xfa/html_utils.js
• src/core/xfa/layout.js
• src/core/xfa/parser.js
• src/core/xfa/som.js
• src/core/xfa/template.js
• src/core/xfa/xdp.js
• src/core/xfa/xfa_object.js
• src/core/xfa/xhtml.js
• src/scripting_api/app.js
• src/scripting_api/event.js
• test/unit/xfa_parser_spec.js
• test/unit/xfa_serialize_data_spec.js

5fad931a3f111665828a7b74e163c1fd9f2818b4 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/5fad931a3f111665828a7b74e163c1fd9f2818b4
Authored: 2023-06-04 09:58:25 +0200
Committed: 2023-06-04 09:58:25 +0200

Enable more import ESLint plugin rules

This patch enables more import rules to help prevent bugs/inconsistencies, and most of these rules didn't require code changes; please find additional details here:

• https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/export.md
• https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/exports-last.md
• https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/first.md
• https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-empty-named-blocks.md
• https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-mutable-exports.md
• https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-self-import.md

Files Modified:

• .eslintrc
• src/display/api.js
• src/display/svg.js

4351708ae62e68f42efe77ca15c1eed2d96ecb73 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/4351708ae62e68f42efe77ca15c1eed2d96ecb73
Authored: 2023-06-01 20:31:05 +0200
Committed: 2023-06-02 22:44:14 +0200

[api-minor] Make the AnnotationLayer an object in order to use it in the AnnotationEditorLayer

It'll be useful to make the Freetext and Ink annotations editable.

Files Modified:

• src/display/annotation_layer.js
• test/driver.js
• web/annotation_layer_builder.js

459d26edec951fcc049928d3a07f8c933a26d3e5 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/459d26edec951fcc049928d3a07f8c933a26d3e5
Authored: 2023-06-02 12:33:36 +0200
Committed: 2023-06-02 17:10:25 +0200

Improve handling of mismatching /BaseFont and /FontName entries for non-embedded fonts (issue 7454)

This patch is the result of me going through some old issues regarding non-embedded Wingdings support.

There's a few different things wrong in the referenced PDF document:

• The /BaseFont and /FontName entries don't agree on the name of the fonts, with one font using /BaseFont /Wingdings-Regular and /FontName /wg09np which obviously makes no sense.
  To address this we'll compare the font-names against our lists of known ones and ignore /FontName entries that don't make sense iff the /BaseFont entry is a known font-name.
• The non-embedded Wingdings font also set an incorrect /Encoding, in this case /MacRomanEncoding, which should have been fixed by PR 16465. However this doesn't work since the font has bogus font-flags, that fail to categorize the font as Symbolic.
  To address this we'll also compare the font-name against the list of known symbol fonts.

Files Added:

• test/pdfs/issue7454.pdf

Files Modified:

• src/core/evaluator.js
• src/core/standard_fonts.js
• test/pdfs/.gitignore
• test/test_manifest.json

ea93c507f5f462503a08e43a0a129f6ec1eae908 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/ea93c507f5f462503a08e43a0a129f6ec1eae908
Authored: 2023-06-02 15:49:34 +0200
Committed: 2023-06-02 16:03:22 +0200

[editor] Initialize KeyboardManager-instances lazily

As far as I can tell there's no particular reason for initializing KeyboardManager-instances eagerly, since the user may never use editing, and we can easily do this lazily instead by utilizing shadowed getters.

Files Modified:

• src/display/editor/freetext.js
• src/display/editor/tools.js

89a17abadf5fc9195c8b5f62619087f379b45ecf by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/89a17abadf5fc9195c8b5f62619087f379b45ecf
Authored: 2023-06-02 13:22:26 +0200
Committed: 2023-06-02 13:22:26 +0200

Enable the import/named ESLint plugin rule

This would've prevented issue 16512, please see https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/named.md

Files Modified:

• .eslintrc

2db0eff70f6b202ff894136b84d1bf148f1641c8 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/2db0eff70f6b202ff894136b84d1bf148f1641c8
Authored: 2023-06-02 10:00:04 +0200
Committed: 2023-06-02 10:02:23 +0200

Fix incorrect USERACTIVATION_CALLBACKID import (15618 follow-up)

This constant is currently imported from the wrong file, where it doesn't exist; see PR 15618.

Files Modified:

• src/scripting_api/event.js

e4ecf59727b665ae6caa73ef9182cb1bee56e371 by Maxence Dalmais

https://github.com/mozilla/pdf.js/commit/e4ecf59727b665ae6caa73ef9182cb1bee56e371
Authored: 2023-06-01 17:42:21 +0200
Committed: 2023-06-02 08:51:18 +0200

export ImageKind type externally

Files Modified:

• src/pdf.js

a60bb5f93694ff7f8d3ff2079af8b8ebfe32d760 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/a60bb5f93694ff7f8d3ff2079af8b8ebfe32d760
Authored: 2023-06-01 18:46:50 +0200
Committed: 2023-06-01 19:01:57 +0200

Don't use partially rendered pages to generate thumbnails when drawingDelay is used (PR 15812 follow-up)

While it's slightly difficult to trigger in practice, unless the defaultZoomDelay-value is increased, it's currently possible to generate thumbnails from partially rendered pages when doing temporary CSS-only zooming.

Files Modified:

• web/pdf_page_view.js

af8df207bb04687b746833c93cb71342362a4d66 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/af8df207bb04687b746833c93cb71342362a4d66
Authored: 2023-06-01 17:44:14 +0200
Committed: 2023-06-01 19:01:50 +0200

Don't dispatch "pagerendered"-events on the temporary CSS-only zooming done when drawingDelay is used (PR 15812 follow-up)

We shouldn't dispatch a "pagerendered"-event when doing temporary CSS-only zooming, but simply wait until the actual rendering is done.
While I don't believe that this regression has caused any actual bugs, dispatching duplicate events is nonetheless inconsistent and should be fixed.

Files Modified:

• web/pdf_page_view.js

1add9bc1310b924a7de1d9adf65751b4004982a9 by Wojciech Maj

https://github.com/mozilla/pdf.js/commit/1add9bc1310b924a7de1d9adf65751b4004982a9
Authored: 2023-06-01 15:41:43 +0200
Committed: 2023-06-01 15:41:43 +0200

Fix canvasMaxAreaInBytes type

Fixes #16503

Files Modified:

• src/display/api.js

0e610cab0422d05446df1037e3b6fef409d76d6a by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/0e610cab0422d05446df1037e3b6fef409d76d6a
Authored: 2023-05-31 18:48:42 +0200
Committed: 2023-05-31 21:17:22 +0200

Try to not omit some values when printing a choice list with several selected items

Files Added:

• test/pdfs/issue16500.pdf

Files Modified:

• src/core/annotation.js
• test/pdfs/.gitignore
• test/test_manifest.json

c60a3ce96a6c2ee944592e3708e001b16e1a9cb2 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/c60a3ce96a6c2ee944592e3708e001b16e1a9cb2
Authored: 2023-05-31 10:47:57 +0200
Committed: 2023-05-31 11:03:39 +0200

[api-minor] Update the minimum supported Google Chrome version to 92

This patch updates the minimum supported browsers as follows:

• Google Chrome 92, which was released on 2021-07-20; see https://support.google.com/chrome/a/answer/10314655

Note that nowadays we usually try, where feasible and possible, to support browsers that are about two years old. By limiting support to only "recent" browsers we reduce the risk of holding back improvements of the built-in Firefox PDF Viewer, and also (significantly) reduce the maintenance/support burden for the PDF.js contributors.

Please note: As always, the minimum supported browser version assumes that a legacy-build of the PDF.js library is being used; see https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support

Files Modified:

• gulpfile.js
• src/shared/compatibility.js

d3c0928121b0780f2baad33fcc3267c07e29ef3f by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/d3c0928121b0780f2baad33fcc3267c07e29ef3f
Authored: 2023-05-31 09:32:19 +0200
Committed: 2023-05-31 09:32:19 +0200

Use the Util.getAxialAlignedBoundingBox helper function more

There's a couple of spots in the code-base that effectively re-implement this helper function, which seems like unnecessary repetition.

Files Modified:

• src/display/canvas.js
• src/display/svg.js
• src/shared/util.js

e8c727742c234e10cafcf47a2e41c6a1f214a000 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/e8c727742c234e10cafcf47a2e41c6a1f214a000
Authored: 2023-05-30 16:48:04 +0200
Committed: 2023-05-30 21:24:19 +0200

Limit some PDFRenderingQueue-related code to the GENERIC viewer

Given that this functionality is only relevant in third-party use-cases, for example the viewer-components, we can avoid needlessly including it in e.g. the MOZCENTRAL build.

Files Modified:

• web/pdf_rendering_queue.js
• web/pdf_viewer.js

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=3dcb5081e16b41695d8cdcd3c2edc3e4c514a6d5

The try push is done, we found jobs with unclassified failures.

Known Issues (From Taskcluster):

• test-windows11-64-2009-qr/opt-mochitest-browser-chrome-spi-nw-1 (T8o5ecNfTe-tVGP4ufzSvQ) - new failure not classified
• test-linux1804-64-qr/debug-mochitest-browser-chrome-editor-legacy-dir-1 (YRC4p_NzS9-3BkbHyYOrnA) - new failure not classified
• test-windows11-64-2009-qr/opt-mochitest-browser-chrome-1 (HAmAVhcGQXeknLPbsscCkA) - new failure not classified
• test-linux1804-64-qr/debug-mochitest-browser-chrome-swr-1 (YP0ab8GbTd6w7u_egYiCdA) - new failure not classified
• test-windows11-64-2009-qr/debug-mochitest-browser-chrome-spi-nw-1 (RLYVEekYTAOXMN9thHqKGQ) - new failure not classified
• test-macosx1015-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (R6N0LaaQS5Cgqu95Yg_H5Q) - new failure not classified
• test-windows11-64-2009-qr/opt-mochitest-browser-chrome-msix-1 (eodiwjW2SG-AjGfcicnPTw) - new failure not classified
• test-windows11-64-2009-qr/debug-mochitest-browser-chrome-swr-1 (RVlb1dQzSCaEgRvUrwP4bA) - new failure not classified
• test-macosx1015-64-qr/opt-mochitest-browser-chrome-spi-nw-1 (Vzkh58q-SYaY8N85SIll2g) - new failure not classified
• test-macosx1015-64-qr/opt-mochitest-browser-chrome-1 (aWSXk-NEQtyOGoFyDbeezA) - new failure not classified
• test-windows11-64-2009-qr/debug-mochitest-browser-chrome-msix-1 (a2lN53aLSaqOODA5-GySiA) - new failure not classified
• test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-1 (IWZlGyKjRMiIw-m5E2BBBQ) - new failure not classified
• test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-1 (cOOdUiYVSZ2yv6-NNinfXg) - new failure not classified
• test-macosx1015-64-qr/debug-mochitest-browser-chrome-1 (GV52wO1jQr-9KmzwbJQsmA) - new failure not classified
• test-linux1804-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (beF1SSlrRmOXMv0dMJeQFg) - new failure not classified
• test-windows11-32-2009-qr/debug-mochitest-browser-chrome-1 (XLt6UM8qR7SesFc9fVrZhw) - new failure not classified
• test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-1 (dlHcNtlMTfmvgtAyuJbZyw) - new failure not classified
• test-windows11-64-2009-qr/debug-mochitest-browser-chrome-1 (GNVgAhNSRGafA95Zp6DhMA) - new failure not classified

Needs Investigation (From Push Health):

• toolkit/components/pdfjs/test/browser_pdfjs_editing_contextmenu.js

  • 18 of 18 failed on different tasks
    - test-linux1804-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (beF1SSlrRmOXMv0dMJeQFg)
    - test-linux1804-64-qr/debug-mochitest-browser-chrome-swr-1 (YP0ab8GbTd6w7u_egYiCdA)
    - test-linux1804-64-qr/debug-mochitest-browser-chrome-editor-legacy-dir-1 (YRC4p_NzS9-3BkbHyYOrnA)
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-1 (cOOdUiYVSZ2yv6-NNinfXg)
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-1 (dlHcNtlMTfmvgtAyuJbZyw)
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-1 (IWZlGyKjRMiIw-m5E2BBBQ)
    - test-windows11-64-2009-qr/opt-mochitest-browser-chrome-1 (HAmAVhcGQXeknLPbsscCkA)
    - test-windows11-64-2009-qr/opt-mochitest-browser-chrome-spi-nw-1 (T8o5ecNfTe-tVGP4ufzSvQ)
    - test-windows11-64-2009-qr/opt-mochitest-browser-chrome-msix-1 (eodiwjW2SG-AjGfcicnPTw)
    - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-1 (GNVgAhNSRGafA95Zp6DhMA)
    - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-spi-nw-1 (RLYVEekYTAOXMN9thHqKGQ)
    - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-swr-1 (RVlb1dQzSCaEgRvUrwP4bA)
    - test-macosx1015-64-qr/debug-mochitest-browser-chrome-1 (GV52wO1jQr-9KmzwbJQsmA)
    - test-macosx1015-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (R6N0LaaQS5Cgqu95Yg_H5Q)
    - test-macosx1015-64-qr/opt-mochitest-browser-chrome-1 (aWSXk-NEQtyOGoFyDbeezA)
    - test-macosx1015-64-qr/opt-mochitest-browser-chrome-spi-nw-1 (Vzkh58q-SYaY8N85SIll2g)
    - test-windows11-32-2009-qr/debug-mochitest-browser-chrome-1 (XLt6UM8qR7SesFc9fVrZhw)
    - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-msix-1 (a2lN53aLSaqOODA5-GySiA)

• toolkit/components/pdfjs/test/browser_pdfjs_editing_telemetry.js

  • 18 of 18 failed on different tasks
    - test-linux1804-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (beF1SSlrRmOXMv0dMJeQFg)
    - test-linux1804-64-qr/debug-mochitest-browser-chrome-swr-1 (YP0ab8GbTd6w7u_egYiCdA)
    - test-linux1804-64-qr/debug-mochitest-browser-chrome-editor-legacy-dir-1 (YRC4p_NzS9-3BkbHyYOrnA)
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-1 (cOOdUiYVSZ2yv6-NNinfXg)
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-1 (dlHcNtlMTfmvgtAyuJbZyw)
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-1 (IWZlGyKjRMiIw-m5E2BBBQ)
    - test-windows11-64-2009-qr/opt-mochitest-browser-chrome-1 (HAmAVhcGQXeknLPbsscCkA)
    - test-windows11-64-2009-qr/opt-mochitest-browser-chrome-spi-nw-1 (T8o5ecNfTe-tVGP4ufzSvQ)
    - test-windows11-64-2009-qr/opt-mochitest-browser-chrome-msix-1 (eodiwjW2SG-AjGfcicnPTw)
    - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-1 (GNVgAhNSRGafA95Zp6DhMA)
    - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-spi-nw-1 (RLYVEekYTAOXMN9thHqKGQ)
    - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-swr-1 (RVlb1dQzSCaEgRvUrwP4bA)
    - test-macosx1015-64-qr/debug-mochitest-browser-chrome-1 (GV52wO1jQr-9KmzwbJQsmA)
    - test-macosx1015-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (R6N0LaaQS5Cgqu95Yg_H5Q)
    - test-macosx1015-64-qr/opt-mochitest-browser-chrome-1 (aWSXk-NEQtyOGoFyDbeezA)
    - test-macosx1015-64-qr/opt-mochitest-browser-chrome-spi-nw-1 (Vzkh58q-SYaY8N85SIll2g)
    - test-windows11-32-2009-qr/debug-mochitest-browser-chrome-1 (XLt6UM8qR7SesFc9fVrZhw)
    - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-msix-1 (a2lN53aLSaqOODA5-GySiA)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor toolkit/components/pdfjs/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

The failing tests should be fixed thanks to:
https://github.com/mozilla/pdf.js/pull/16533
which I included in this release.

A try:
https://treeherder.mozilla.org/jobs?repo=try&revision=85aa1824864fd9cd7aa1636f5ff0b73f557095a6

https://hg.mozilla.org/mozilla-central/rev/bbf9192562d3