Closed Bug 1837619 Opened 1 year ago Closed 1 year ago

Previously imported number of bookmarks from HTML files are displayed when importing bookmarks HTML files again

Categories

(Firefox :: Migration, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
116 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox114 --- unaffected
firefox115 --- verified
firefox116 --- verified

People

(Reporter: atrif, Assigned: mconley)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Found in

  • 115.0b3

Affected versions

  • 116.0a1 (2023-06-08)
  • 115.0b3

Tested platforms

  • Affected platforms: Windows10 x64, Ubuntu 20.04, macOS 12
  • Unaffected platforms: none

Preconditions

  • browser.migrate.content-modal.enabled
  • exported bookmarks.html file

Steps to reproduce

  1. Open the new migration window and select Bookmarks from HTML file.
  2. Import the .html file.
  3. Import again using the Bookmarks from HTML file option and observe the importing window.

Expected result

  • Previously imported number of bookmarks is not displayed.

Actual result

  • Previously imported number of bookmarks is displayed.

Regression range

  • Not a regression, it started happening with the implementation of Bookmark importing from HTML files (bug 1833427).

Additional notes

  • Attached a screen recording.
  • This is very hard to be seen on fast computers due to importing speed. It’s most visible on low-end computers.

:atrif, if you think that's a regression, could you try to find a regression range using for example mozregression?

Assignee: nobody → mconley
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1a7c806e2c8d Make sure to clear the file progress status message when going back to in-progress. r=kpatenio
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(mconley)

Issue is verified-fixed on build provided on treeherder.

Status: RESOLVED → VERIFIED

Comment on attachment 9338322 [details]
Bug 1837619 - Make sure to clear the file progress status message when going back to in-progress. r?kpatenio!

Beta/Release Uplift Approval Request

  • User impact if declined: Users that import bookmarks from files more than once using the same instance of the migration wizard will see the previous count of imported bookmarks during the import progress.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a well-understood one-liner fix with an automated test.
  • String changes made/needed: None.
  • Is Android affected?: No
Flags: needinfo?(mconley)
Attachment #9338322 - Flags: approval-mozilla-beta?

Comment on attachment 9338322 [details]
Bug 1837619 - Make sure to clear the file progress status message when going back to in-progress. r?kpatenio!

Approved for 115.0b6.

Attachment #9338322 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Issue is verified-fixed on 115.0b6 Firefox.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: