Closed Bug 1837835 Opened 1 year ago Closed 1 year ago

Firefox incorrectly allows overriding non-replaceable properties, e.g. with "navigator.gpu = {};"

Categories

(Core :: Graphics: WebGPU, defect, P3)

Product:
Core
Component:
Graphics: WebGPU
Version:
Firefox 114
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: jujjyl, Assigned: ErichDonGubler)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1837835: fix(webgpu): remove `Replaceable` IDL attr. for `NavigatorGPU` r=#webgpu-reviewers
(deleted), text/x-phabricator-request
Details

Not sure if this is specifically a WebGPU IDL problem or a JS engine problem, but reporting to JS engine side at first, feel free to route if this is a WebGPU IDL issue.

STR:

  1. run in Firefox Nightly console:
navigator.gpu = {};

and then prompt navigator.gpu in the console window to see what it prints out.

Observed: Firefox prints out

Object { }

Expected: Firefox prints out

GPU { }

that is, it should not be possible to assign over navigator.gpu.

See https://github.com/gpuweb/gpuweb/issues/4150 for more details.

Type: task → defect
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → Firefox 114
Component: JavaScript Engine → Graphics: WebGPU
Blocks: webgpu-v1
Severity: -- → S3
Priority: -- → P3
Assignee: nobody → egubler
Status: NEW → ASSIGNED
Attachment #9344927 - Attachment description: Bug 1837835: fix(webgpu): remove `Replaceable` IDL attr. for `GPUProvider` r=#webgpu-reviewers → Bug 1837835: fix(webgpu): remove `Replaceable` IDL attr. for `NavigatorGPU` r=#webgpu-reviewers
Pushed by egubler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82f323c35c8c
fix(webgpu): remove `Replaceable` IDL attr. for `NavigatorGPU` r=webgpu-reviewers,webidl,saschanaz,jgilbert

https://hg.mozilla.org/mozilla-central/rev/82f323c35c8c

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: