Closed Bug 1838080 Opened 1 year ago Closed 1 year ago

libwebrtc needs a few bugfixes to support RTCRtpScriptTransform

Categories

(Core :: WebRTC: Audio/Video, defect)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: bwc, Assigned: bwc, NeedInfo)

References

Details

Attachments

(5 files)

Bug 1838080: Remove this duplicate init (that's also on the wrong thread). r?pehrsons
(deleted), text/x-phabricator-request
Details
Bug 1838080: Work around a race in ChannelSendFrameTransformerDelegate. r?pehrsons
(deleted), text/x-phabricator-request
Details
Bug 1838080: Use the current TaskQueue, instead of the current thread, to init this. r?pehrsons
(deleted), text/x-phabricator-request
Details
Bug 1838080: Store the rid in TransformableVideoSenderFrame. r?ng
(deleted), text/x-phabricator-request
Details
Bug 1838080: Ensure that last ref to transformation_queue_ is not released on itself. r?pehrsons
(deleted), text/x-phabricator-request
Details
No description provided.
Assignee: nobody → docfaraday

This was causing assertions.

This variable can be null when a ChannelSendFrameTransformerDelegate is in use,
because that does an async dispatch to the encoder queue in the handling for
transformed frames. If this is unset while that dispatch is in flight, we
nullptr crash.

Depends on D179731

There are situations where the current thread is not set, but the current
TaskQueue is (but not vice versa).

Depends on D180735

This is necessary to reliably detect what rid a given keyframe is for, for the
purposes of resolving promises from RTCRtpScriptTransformer.generateKeyFrame.

Depends on D180736

The severity field is not set for this bug.
:jib, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jib)
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6f5162d90ff3 Remove this duplicate init (that's also on the wrong thread). r=pehrsons,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/c0f042536365 Work around a race in ChannelSendFrameTransformerDelegate. r=pehrsons,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/f3a099a2173c Use the current TaskQueue, instead of the current thread, to init this. r=pehrsons,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/3f41779ac63f Store the rid in TransformableVideoSenderFrame. r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/0fb0b9a4e151 Ensure that last ref to transformation_queue_ is not released on itself. r=pehrsons,webrtc-reviewers

Backed out for causing VideoConduitTest related failures

Backout link

Push with failures

Failure log

Flags: needinfo?(docfaraday)
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/86fcc8ba6779 Remove this duplicate init (that's also on the wrong thread). r=pehrsons,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/a614605b47ee Work around a race in ChannelSendFrameTransformerDelegate. r=pehrsons,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/6c10370ed682 Use the current TaskQueue, instead of the current thread, to init this. r=pehrsons,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/1eb303981213 Store the rid in TransformableVideoSenderFrame. r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/e091677e39fa Ensure that last ref to transformation_queue_ is not released on itself. r=pehrsons,webrtc-reviewers

Backed out for causing wpt failures in script-transform-generateKeyFrame.https.html

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-TIMEOUT | /webrtc-encoded-transform/script-transform-generateKeyFrame.https.html | generateKeyFrame works with simulcast rids - Test timed out
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ac6592a04a8 Remove this duplicate init (that's also on the wrong thread). r=pehrsons,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/56555ecee7f3 Work around a race in ChannelSendFrameTransformerDelegate. r=pehrsons,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/62e71a2f745c Use the current TaskQueue, instead of the current thread, to init this. r=pehrsons,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/2f1a0ba74bf7 Store the rid in TransformableVideoSenderFrame. r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/91d9e8b6a5c4 Ensure that last ref to transformation_queue_ is not released on itself. r=pehrsons,webrtc-reviewers
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41149 for changes under testing/web-platform/tests
Upstream PR was closed without merging
Flags: needinfo?(docfaraday)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: