Jimmy Lee Reporter
	Description • 25 years ago

Build: 1999-11-09-11-M11(WIN), 1999-11-09-08-M11(MAC), 1999-11-09-11-M11(LINUX)

1. From http://jimbob/trigger.htm, trigger
http://jimbob/jars/f_fileop_dircreate_nested.xpi

Install.StartInstall("Functional: f_fileop_dircreate_nested",
"f_fileop_dircreate_nested", "1.1.1.1", 0);
f = Install.GetFolder("Program");
err1 = Install.DirCreate(f +
"f_fileop_dircreate_nested/байинмутъщзвкофы/111/222/AAA/BBB");
Install.LogComment("Nested DirCreate returns = " + err1);
err2 = Install.DirCreate(f + " ");
Install.LogComment("One blank character DirCreate returns = " + err2);
err3 = Install.DirCreate(f + "");
Install.LogComment("No characters DirCreate returns = " + err3);

RESULT:
No directories are created.  The Install.log reports:

---------------------------------------------------------------------------
http://jimbob/jars/f_fileop_dircreate_nested.xpi     --     11/09/1999 15:27:03
---------------------------------------------------------------------------

     Functional: f_fileop_dircreate_nested
     -------------------------------------

     ** ERROR (-230): Create Folder: C:\Program
Files\moz119\f_fileop_dircreate_nested\байинмутъщзвкофы\111\222\AAA\BBB
     ** Nested DirCreate returns = -230
     ** ERROR (-230): Create Folder: C:\Program Files\moz119\
     ** One blank character DirCreate returns = -230
     ** ERROR (-230): Create Folder: C:\Program Files\moz119\
     ** No characters DirCreate returns = -230

     Install script aborted
     Finished Installation  11/09/1999 15:27:04

EXPECTED RESULT:
Unlike what -230 indicates (ALREADY_EXISTS), the directories do not exist.  The
directories should be created.

	Jimmy Lee Reporter
	Comment 1 • 25 years ago

Forgot to add Summary.  Here it is!

	Sean Su
	Comment 2 • 25 years ago

This should not be returning error -230.  it should be -201 (unexpected_error)
or a new error value indicating that a target directory could not be created.

reassigning this to myself.

	leger
	Comment 3 • 25 years ago

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine

	Daniel Veditz [:dveditz]
	Comment 4 • 25 years ago

Post beta

	Sean Su
	Comment 5 • 25 years ago

mass change to M16

	Cathleen
	Comment 6 • 25 years ago

need help verify

	Jimmy Lee Reporter
	Comment 7 • 25 years ago

Builds: 2000-05-03-08-M16(LINUX), 2000-05-08-09-M16(WIN), 2000-05-08-08-M16(MAC)

The problem is still present.  However, looking at the install script, we see 
that I originally was testing characters like байинмутъщзвкофы.  I believe we 
are no longer supported this character set.

Please confirm, Cathleen.  Thanks.

	Cathleen
	Comment 8 • 25 years ago

reassigning to doug.  :-)

	Mike
	Comment 9 • 24 years ago

M16 has been out for a while now, these bugs target milestones need to be 
updated.

	Daniel Veditz [:dveditz]
	Comment 10 • 24 years ago

Parecelling out Cathleen's bugs

	Jimmy Lee Reporter
	Comment 11 • 24 years ago

Build: 2000-08-02-05-M17(WIN), 2000-08-02-04-M17(MAC), 2000-08-02-04-M17(LINUX)

The subdirectory /BBB is not getting created from any platform.

Install.log:
-------------------------------------------------------------------------------
http://jimbob/jars/f_fileop_dircreate_nested.xpi  --  08/02/2000 11:26:04
-------------------------------------------------------------------------------

     Functional: f_fileop_dircreate_nested
     -------------------------------------

     ** Nested DirCreate returns = 0
     ** ERROR (-230): Create Folder: C:\Program Files\Netscape\Netscape 6\ 
     ** One blank character DirCreate returns = -230
     ** ERROR (-230): Create Folder: C:\Program Files\Netscape\Netscape 6
     ** No characters DirCreate returns = -230

     Install cancelled by script
     Finished Installation  08/02/2000 11:26:04

	David Epstein
	Comment 12 • 24 years ago

nominated nsbeta3 by QA. impact is that dircreate is not completely working as 
expected.

	Daniel Veditz [:dveditz]
	Comment 13 • 24 years ago

Multiple directory creation (as in the summary) works -- fixed.

trailing " " is not a bug -- that's what the os will return when you try to 
create "dir1\dir2\ ".

creating "dir\" when "dir" already exists will return already exists from the 
OS, not a bug.

	Jimmy Lee Reporter
	Comment 14 • 24 years ago

Build: 2000-08-21-08-M18(WIN), 2000-08-21-08-M18(MAC), 2000-08-17-13-M18(LINUX)

Please see comment from 2000-08-02 11:35.

The last subdirectory (\BBB) is still not being created.  Marking Reopen.

	Daniel Veditz [:dveditz]
	Comment 15 • 24 years ago

Reassigning for load balancing and investigation.

	dbragg
	Comment 16 • 24 years ago

Per discussion with dougt, this looks like a bug in the nsLocalFile-platform.cpp 
code.  If the path passed doesn't end with a file separator, the code Create 
code doesn't create the last directory.  The test case listed in the bug report 
is very good for tracing this bug.

Reassigning to Dougt.

	Doug Turner (:dougt) Assignee
	Comment 17 • 24 years ago

I do not think that this is a bug with nsIFile anymore.  (if it is reassign with
comment).  In the script you are aborting if there are any errors.  The abort
will remove any directories that you created (minus any ancestors).  If you
remove this abort, the terminal node gets created just fine.

Why are you getting an error in the first place? Probably because doing:

getFolder("Program", "");

is illegal.


Marking INVALID.

	Jimmy Lee Reporter
	Comment 18 • 24 years ago

Build: 2000-08-29-08-M18(WIN), 2000-08-29-08-M18(MAC), 2000-08-29-06-M18(LINUX)

A new test at http://jimbob/jars/18381_bug.xpi verifies that if no errors are 
returned then the directories are created as expected.  Unfortunately, I do not 
know why the last directory is not created when an error is received.

Marking Verified.

	Doug Turner (:dougt) Assignee
	Comment 19 • 24 years ago

The last directory is removed when an abort happens.  It is a bug that all of
the parents are not removed. (you should file something against ssu)