Open Bug 1838152 Opened 1 year ago Updated 1 year ago

Improve error message when sending session.new without capabilities

Categories

(Remote Protocol :: WebDriver BiDi, defect, P3)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
defect

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned, Mentored)

References

Details

(Whiteboard: [lang=js])

I was using the client to connect to bidi at https://juliandescottes.github.io/bidi-web-client/web/ , and I usually just send an empty session.new command to create the session, but this now fails with a cryptic error message:

Expected [object Undefined] undefined to be an object

We should add a custom message on the following assert so that users know that the issue is a missing capabilities parameter perhaps?

export function processCapabilities(params) {
  const { capabilities } = params;
  lazy.assert.object(capabilities);

Sasha: just a quick ping for you to check if this bug is valid?

Flags: needinfo?(aborovova)

Yeah, I agree, adding the custom message here would be better for the users.

Flags: needinfo?(aborovova)
Mentor: aborovova
Severity: -- → S3
Priority: -- → P3
Whiteboard: [lang=js]
You need to log in before you can comment on or make changes to this bug.