Add preference for controlling `audio/` and `video/` ORB exemptions
Categories
(Core :: DOM: Networking, task, P2)
Tracking
()
People
(Reporter: farre, Assigned: farre)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(2 files)
|
(deleted),
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details |
|
(deleted),
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details |
In IsOpaqueSafeListedSpecBreakingMIMEType we want to extend the code that adds exceptions for media MIME types
|
Assignee | |
Comment 1•1 year ago
|
||
Instead of doing:
if (aContentType.EqualsLiteral(AUDIO_MP3) ||
aContentType.EqualsLiteral(AUDIO_AAC)) {
return true;
}
I'd guess we'd want to do something like:
switch (StaticPrefs::browser_opaqueResponseBlocking_mediaExceptionsStrategy() {
case OpaqueResponseMediaException::NoExceptions:
break;
case OpaqueResponseMediaException::AllowSome:
if (aContentType.EqualsLiteral(AUDIO_MP3) ||
aContentType.EqualsLiteral(AUDIO_AAC)) {
return true;
}
break;
case OpaqueResponseMediaException::AllowAll:
if (StringBeginsWith(aContentType, "audio/"_ns) ||
StringBeginsWith(aContentType, "video/"_ns)) {
return true;
}
break;
|
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
In IsOpaqueSafeListedSpecBreakingMIMEType we make it possible to
configure, with pref, what kind of exception strategy to use to handle
compatibility problems with MIME types starting with audio/ or
video/.
|
|
Assignee | |
Updated•1 year ago
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D180926
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fe364999eb7b
https://hg.mozilla.org/mozilla-central/rev/ccd60b2ac497
|
|
Assignee | |
Comment 6•1 year ago
|
||
Comment on attachment 9339068 [details]
Bug 1838208 - Part 2: Add opaqueResponseBlocking.mediaExceptionsStrategy to Nimbus. r=sefeng!
Beta/Release Uplift Approval Request
- User impact if declined: Delaying ORB rollout. browser.opaqueResponseBlocking.mediaExceptionsStrategy is needed for risk mitigation.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: 1) For all values of browser.opaqueResponseBlocking.mediaExceptionsStrategy (0, 1, and 2) do
1.1) Visit https://www.radios.com.br/aovivo/radio-candeias-1069-fm/16177
1.2) If browser.opaqueResponseBlocking.mediaExceptionsStrategy is 0 check that the audio is not playable, else check that it is playable. - List of other uplifts needed: Bug 1838052
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The default value of the pref is the current behaviour, pref values 0 and 2 aren't used.
- String changes made/needed: None
- Is Android affected?: Yes
|
|
Assignee | |
Updated•1 year ago
|
|
||
Comment 7•1 year ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/c8204e5978a8
https://hg.mozilla.org/releases/mozilla-beta/rev/f2badb4de583
|
|
||
Comment 8•1 year ago
|
||
Comment on attachment 9339024 [details]
Bug 1838208 - Part 1: Add pref to allow choosing exception strategy. r=sefeng!
Approved for 115.0b6.
|
|
||
Comment 9•1 year ago
|
||
Comment on attachment 9339068 [details]
Bug 1838208 - Part 2: Add opaqueResponseBlocking.mediaExceptionsStrategy to Nimbus. r=sefeng!
Approved for 115.0b6.
|
||
Updated•1 year ago
|
|
||
Comment 10•1 year ago
|
||
I have verified that the "browser.opaqueResponseBlocking.mediaExceptionsStrategy" pref has been successfully added with the default value of "1" on Beta 115.0b6 and Nightly 116.0a1 and that the audio is not playable on https://www.radios.com.br/aovivo/radio-candeias-1069-fm/16177 with it set to "0". I've done this across Windows 10, MacOS 11.6 and Ubuntu 20.04.
Description
•