Closed
Bug 1838708
Opened 1 years ago
Closed 1 years ago
Remove legacy kinto web extension sync keys form user account state
Categories
(Firefox :: Firefox Accounts, task, P4)
Firefox
Firefox Accounts
Tracking
()
RESOLVED
FIXED
116 Branch
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: teshaq, Assigned: teshaq)
References
Details
(Whiteboard: [fxsync-])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The old Kinto web ext storage used to have it's own sync keys, which has since been replaced with Firefox sync keys.
This ticket is to remove the old web ext storage scopedKey and the legacy high-level kExtSync and kExtKbHash entries in the user's account state.
Note that this completely breaks old kinto sync, but that's decommissioned and due to be removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1637465 and https://bugzilla.mozilla.org/show_bug.cgi?id=1803748
|
||
Updated•1 years ago
|
|
Assignee | |
Comment 1•1 years ago
|
||
|
|
Assignee | |
Comment 2•1 years ago
|
||
Besides a try run in https://treeherder.mozilla.org/jobs?repo=try&revision=ee1879e418a9c0546a8f200cd8c82da862d3b671 and running automated tests locally, I verified the removal is OK by manually upgrading a local build:
- Checked out the default branch
- Built and ran Firefox
- Signed in to a firefox account
- in the browser toolbox, ran
await fxAccounts._internal.getUserAccountData()and verified thatkExtSync,kExtKbHashandscopedKeys["sync:addon_storage"]exist. - Checkout out my branch
- built and ran Firefox
- in the browser toolbox, ran
await fxAccounts._internal.getUserAccountData()and verified thatkExtSync,kExtKbHashandscopedKeys["sync:addon_storage"]DO NOT exist - verified sync works as expected.
Pushed by teshaq@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66787f25062d
Removes legacy webext storage keys from account state. r=markh,sync-reviewers
|
||
Comment 4•1 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 years ago
status-firefox116:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•