Open Bug 1838829 Opened 1 year ago Updated 1 year ago

Make mochitest support Http/2 test server

Categories

(Core :: Networking, task, P2)

Product:
Core
Component:
Networking
Type:
task

Tracking

()

People

(Reporter: kershaw, Assigned: kershaw)

References

(Blocks 1 open bug)

Details

(Keywords: leave-open, Whiteboard: [necko-triaged])

Attachments

(6 files)

Bug 1838829 - Update subjectAlternativeName for mochitest, r=#necko
(deleted), text/x-phabricator-request
Details
Bug 1838829 - Add Http/2 test server in mochitest, r=#necko
(deleted), text/x-phabricator-request
Details
Bug 1838829 - Make CI support running mochtiest with Http/2, r=#necko
(deleted), text/x-phabricator-request
Details
Bug 1838829 - Skip failed tests, r=#necko
(deleted), text/x-phabricator-request
Details
Bug 1838829 - Add document for mochitest with Http/2 and Http/3, r=#necko
(deleted), text/x-phabricator-request
Details
Bug 1838829 - Make Http/2 server support websocket, r=#necko
(deleted), text/x-phabricator-request
Details
No description provided.

This is to make the server support usual origins in mochitest

Depends on D181248

Depends on D181249

Depends on D181250

Blocks: 1827526
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1a8cf3c83dc4 Update subjectAlternativeName for mochitest, r=necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/e125be49d2a6 Add Http/2 test server in mochitest, r=necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/5e51feff7467 Make CI support running mochtiest with Http/2, r=necko-reviewers,ci-and-tooling,aryx,valentin https://hg.mozilla.org/integration/autoland/rev/903d9ff4afaa Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu https://hg.mozilla.org/integration/autoland/rev/693d34c8447d Add document for mochitest with Http/2 and Http/3, r=necko-reviewers,valentin

Backed out for causing perma mochitest failure with dom/websocket/tests being skipped

Backout link

Push with failures

Failure log

Flags: needinfo?(kershaw)
Flags: needinfo?(kershaw)
Keywords: leave-open
Attachment #9339553 - Attachment description: Bug 1838829 - Make CI support running mochtiest with Http/2, r=#necko → Bug 1838829 - Make CI support running mochtiest with Http/2, r=#necko
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f68fb3f6316 Update subjectAlternativeName for mochitest, r=necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/3e4df1f9159e Add Http/2 test server in mochitest, r=necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/739abf44b439 Add document for mochitest with Http/2 and Http/3, r=necko-reviewers,valentin

(In reply to Norisz Fay [:noriszfay] from comment #7)

Backed out for causing perma mochitest failure with dom/websocket/tests being skipped

Backout link

Push with failures

Failure log

This try run looks green, so I'll try to land this again.

Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/97cd8a256954 Make CI support running mochtiest with Http/2, r=necko-reviewers,ci-and-tooling,aryx,valentin https://hg.mozilla.org/integration/autoland/rev/19a5d4f1850a Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu

Backed out for causing perma mochitest failure with dom/websocket/tests being skipped

Backout link

Push with failures

Failure log

The failure appears only when it is running the dom/websocket/tests/mochitest.ini test group. In the try run linked this specific test group hasn't ran, that is why it turned green. I hope this info helps to further investigate the issue at hand.

Flags: needinfo?(kershaw)

https://treeherder.mozilla.org/jobs?repo=try&revision=f2e251a18c1d31b8d7bbf3a781c958d46bf928be&selectedTaskRun=MThdHuI1SZKYLOT-3pzE1g.0

I've tried to add one test in dom/websocket/tests that can pass with HTTP/2 server.

Flags: needinfo?(kershaw)
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47c04252d09d Make CI support running mochtiest with Http/2, r=necko-reviewers,ci-and-tooling,aryx,valentin https://hg.mozilla.org/integration/autoland/rev/81d932c90d6d Skip failed tests, r=necko-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,dimi,valentin,robwu https://hg.mozilla.org/integration/autoland/rev/6a2a4435c13d Make Http/2 server support websocket, r=necko-reviewers,valentin

I just found an insecure context test is affected: https://searchfox.org/mozilla-central/rev/77dd6aa3810610949a5ff925e24de2f8c11377fd/dom/notification/test/mochitest/mochitest.ini#15-18

# This test needs to be run on HTTP (not HTTPS).
[test_notification_insecure_context.html]
skip-if =
  http3
  http2

Does this mean HTTP2/3 configurations implicitly run all tests in HTTPS?

Flags: needinfo?(kershaw)

(In reply to Kagami [:saschanaz] (they/them) from comment #19)

I just found an insecure context test is affected: https://searchfox.org/mozilla-central/rev/77dd6aa3810610949a5ff925e24de2f8c11377fd/dom/notification/test/mochitest/mochitest.ini#15-18

# This test needs to be run on HTTP (not HTTPS).
[test_notification_insecure_context.html]
skip-if =
  http3
  http2

Does this mean HTTP2/3 configurations implicitly run all tests in HTTPS?

Yes, please see the explanation here.
All HTTP requests will be upgraded to HTTPS when running with a HTTP/2/3 server.

Flags: needinfo?(kershaw)

I wonder scheme = http makes more sense in that case. I can make that change. (Edit: it didn't work, --use-http2-server should skip scheme=http but it does not 🤔)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: