Closed Bug 1839054 Opened 1 year ago Closed 1 year ago

Enable QPACK dynamic table on Android

Categories

(Core :: Networking: HTTP, enhancement, P2)

Unspecified
Android
enhancement

Tracking

()

RESOLVED FIXED
117 Branch
Tracking Status
firefox117 --- fixed

People

(Reporter: gregp, Assigned: kershaw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

QPACK dynamic table was disabled on desktop and mobile in bug 1628460. It was later re-enabled in bug 1655782, but only on desktop.

Blocks: QUIC
Severity: -- → N/A
Priority: -- → P2
Whiteboard: [necko-triaged
Whiteboard: [necko-triaged → [necko-triaged]

Hey Martin,
Just wanted to check if you had any concerns around re-enabling this on Android.
Thanks.

Flags: needinfo?(mt)

:kershaw can you take a look at this? I think that - given the time involved - the unspecified problem is OK, so we should just turn this back on (and give our Android users better performance).

Flags: needinfo?(mt) → needinfo?(kershaw)

Worth noting also: the original table size was 4k for Android. We can probably afford a larger table. 16k at least, though 64k to match desktop is probably fine. Most Android devices have multiple Gb of RAM, so a few kilobytes per connection won't hurt that much. Other decompressors can use a lot more memory than that (zlib uses 40k and that's an old, lightweight algorithm).

(In reply to Martin Thomson [:mt:] from comment #3)

Worth noting also: the original table size was 4k for Android. We can probably afford a larger table. 16k at least, though 64k to match desktop is probably fine. Most Android devices have multiple Gb of RAM, so a few kilobytes per connection won't hurt that much. Other decompressors can use a lot more memory than that (zlib uses 40k and that's an old, lightweight algorithm).

Thanks. I 64k should be fine. Will submit a patch soon.

Flags: needinfo?(kershaw)
Assignee: nobody → kershaw
Status: NEW → ASSIGNED
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5229dccdcd33 Enable QPACK on Android, r=necko-reviewers,geckoview-reviewers,jesup,amejiamarmol
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: