Closed Bug 1839809 Opened 1 year ago Closed 1 year ago

VR video slow - ClientWebGLContext::TexImage takes slow path, BlitPreventReason() fails with format is not RGBA error.

Categories

(Core :: Audio/Video: Playback, defect)

Firefox 114
x86_64
Linux
defect

Tracking

()

RESOLVED DUPLICATE of bug 1769747
Performance Impact ?

People

(Reporter: elfarto, Unassigned)

References

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/114.0

Steps to reproduce:

Play this video: https://vimeo.com/channels/360vr/277503248

Actual results:

The playback is very laggy, on both Firefox 114 and a recent Firefox nightly (20230620094433).

Expected results:

The playback should be smooth.

This seems to be related to bug 1809026, however the video in that issue still plays back fine, without lag, so there's clearly something different with this video that's breaking the previous fix.

I've uploaded a profile of the issue on Firefox nightly: https://share.firefox.dev/3qMlGFR

OS: Unspecified → Linux
Hardware: Unspecified → x86_64

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core

btw. Looks like https://phabricator.services.mozilla.com/D167240 is broken somehow so we don't use fast path for dmabuf surfaces.

Performance Impact: --- → ?
Severity: -- → S3

This doesn't look like a regression - https://www.youtube.com/watch?v=FWYzdJJVpIQ works as before.
Looks like this particular video ( https://vimeo.com/channels/360vr/277503248 ) is somehow broken SW rendering path is taken.

Looks like we're missing dmabuf upload path in ClientWebGLContext::TexImage().

Flags: needinfo?(stransky)
Summary: VR video slow VA-API → VR video slow VA-API (dmabuf support missing at ClientWebGLContext::TexImage())

It fails in BlitPreventReason() with format is not RGBA error.
Looks like a general error which is not VA-API specific, pi.format is LOCAL_GL_RGB.

Summary: VR video slow VA-API (dmabuf support missing at ClientWebGLContext::TexImage()) → VR video slow - BlitPreventReason() with format is not RGBA error.

It's not VA-API specific, I think it affects all other HW decode backends.

No longer blocks: egl-linux-vaapi
Summary: VR video slow - BlitPreventReason() with format is not RGBA error. → VR video slow - ClientWebGLContext::TexImage takes slow path, BlitPreventReason() fails with format is not RGBA error.

https://phabricator.services.mozilla.com/D167159 fixes this one for me. But Bug 1769747 has more general approach.

Status: UNCONFIRMED → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1769747
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.