Closed
Bug 1839814
Opened 1 year ago
Closed 1 year ago
Move `nsIEditor.wrapWidth` to `nsIEditorMailSupport`
Categories
(Core :: DOM: Editor, task, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
116 Branch
Tracking | Status | |
---|---|---|
firefox116 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
It's used only by the mail composers, but the value needs to be stored for EditorBase::GetAndInitDocEncoder()
. Therefore, we cannot move it into comm-central.
Assignee | ||
Comment 1•1 year ago
|
||
It's used only by the mail composers. However, EditorBase::mWrapColumn
is
also used by TextEditor
. Therefore, EditorBase
still needs to manage the
member, but the setters, SetWrapColumn()
and SetWrapWidth()
can be in
TextEditor
and HTMLEditor
.
Depends on D181835
Assignee | ||
Comment 2•1 year ago
|
||
nsIEditor.wrapWidth
is moved into nsIEditorMailSupport
since it's used only
by the email composers. Therefore, some callers need to QI from nsIEditor
.
(FYI: QI is expensive so that doing it in GetCurrentEditor()
by default seems
risky for the performance.)
Assignee | ||
Updated•1 year ago
|
Keywords: leave-open
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/comm-central/rev/4acda6e7aa2f
QI `nsIEditorMailSupport` when accessing its `wrapWidth` r=mkmelin
Assignee | ||
Updated•1 year ago
|
Keywords: leave-open
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/35b70265e584
Move `nsIEditor.wrapWidth` to `nsIEditorMailSupport` r=m_kato
Comment 5•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox116:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•