Closed Bug 1839872 Opened 1 year ago Closed 1 year ago

Migration wizard remains in infinite loading when importing .HTML or .CSV files even if the data is successfully imported

Categories

(Firefox :: Migration, defect, P1)

Firefox 116
Desktop
All
defect

Tracking

()

VERIFIED FIXED
116 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox114 --- unaffected
firefox115 --- unaffected
firefox116 --- verified

People

(Reporter: gmoldovan, Assigned: mconley)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image infinite loop (deleted) —

Found in

  • Nightly 116.0a1

Affected versions

  • 116.0a1 (20230621040008)

Tested platforms

Affected platforms:

  • Ubuntu 22
  • Windows 10
  • macOS 10.14

Preconditions

  • Ensure “signon.management.page.fileImport.enabled" is set on True in about:config.
  • have a valid csv file with exported passwords from any browser

Steps to reproduce

  1. Open Firefox and choose to import Passwords from CSV file.
  2. Select the file from the preconditions.

Expected result
The import is successful.

Actual result
The import does not complete, it remains in progress in an infinite loop.

Regression range
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=693d34c8447d4730b61eaad4858422001bdb1a7e&tochange=b865b19797f1adb2019d2845b4ad65c34869a433

Notes

  • Screenshot attached
Blocks: 1838867
No longer blocks: 1827857
Summary: Migration wizard remains in infinite loading when importing .HTML or .csv files even if the data is successfully imported → Migration wizard remains in infinite loading when importing .HTML or .CSV files even if the data is successfully imported
Assignee: nobody → mconley
Priority: -- → P1
Keywords: regression
Regressed by: 1836555

In bug 1836555, we changed the progress update messages from MigrationWizardParent
from being a binary "in progress" and "not in progress" to a series of possible
values defined under MigrationWizardConstants.PROGRESS_VALUE.

We forgot to update the file migrators to use this, and they were still using
the old inProgress flag. This means that the migration occurred, but progress
updates weren't properly displayed.

We had a test for this, but the test was actually broken - it was querying for
the progress groups using a broken query selector. I've fixed the test, added
an additional check to ensure that the progress icons are in the completed
state, and confirmed that the test fails without the fix, and passes with it.

Set release status flags based on info from the regressing bug 1836555

Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/065d32f0f32e Fix progress and success states for file migrators. r=kpatenio
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

Verified as fixed on the latest Nightly build (20230623092529) using Windows 10, Ubuntu 22.04 and macOS 12. The migration wizard no longer remains in infinite loading when importing .HTML or .CSV files.

Status: RESOLVED → VERIFIED

Set release status flags based on info from the regressing bug 1836555

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: