Closed Bug 1840007 Opened 1 year ago Closed 1 year ago

Thread tree's current index isn't correctly displayed sometimes

Categories

(Thunderbird :: Folder and Message Lists, defect, P2)

Tracking

(thunderbird_esr115+ fixed)

RESOLVED FIXED
116 Branch
Tracking Status
thunderbird_esr115 + fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [supernova3p])

Attachments

(1 file)

The row with the current class can get out of sync with reality, if the TreeSelection's currentIndex property is updated directly, not through the tree's methods. I've found two places where this occurs:

  • nsMsgDBView::RestoreSelection sets the property directly.
  • TreeSelection's adjustSelection method updates the index.

… and some other selection oddities discovered along the way.

Severity: -- → S3
Priority: -- → P2
Blocks: sn-msglist
Whiteboard: [supernova3p]
Target Milestone: --- → 116 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f4ecceb0af98
Update the thread tree when the current index changes. r=freaktechnik

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Comment on attachment 9340630 [details]
Bug 1840007 - Update the thread tree when the current index changes. r=aleca,freaktechnik

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: message list out of touch with reality, not updated when the current row changes
Testing completed (on c-c, etc.): in 116
Risk to taking this patch (and alternatives if risky): low

Attachment #9340630 - Flags: approval-comm-esr115?

Comment on attachment 9340630 [details]
Bug 1840007 - Update the thread tree when the current index changes. r=aleca,freaktechnik

[Triage Comment]
approved for esr115

Attachment #9340630 - Flags: approval-comm-esr115? → approval-comm-esr115+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: