Closed Bug 1840356 Opened 1 year ago Closed 1 year ago

Intermittent TVw leakcheck | default 4720 bytes leaked (EarlyHintPreloader, ParentChannelListener, ServiceWorkerInterceptController)

Categories

(Core :: Networking: HTTP, defect, P5)

defect

Tracking

()

RESOLVED FIXED
117 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox114 --- unaffected
firefox115 --- unaffected
firefox116 --- wontfix
firefox117 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: zqianem)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, regression, test-verify-fail, Whiteboard: [necko-triaged])

Attachments

(1 file)

Filed by: sstanca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=420613950&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aZAW2T0ASV6x7IB9M__98g/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aZAW2T0ASV6x7IB9M__98g/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


[task 2023-06-26T11:16:01.545Z] 11:16:01     INFO - TEST-PASS | leakcheck | utility no leaks detected!
[task 2023-06-26T11:16:01.545Z] 11:16:01     INFO - leakcheck | Processing leak log file /var/folders/_s/31zcqkls21n2x5vcfxygc3hc000014/T/tmpbq_ll4f_/runtests_leaks_2255.log
[task 2023-06-26T11:16:01.546Z] 11:16:01     INFO - 
[task 2023-06-26T11:16:01.546Z] 11:16:01     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, default process 2338
[task 2023-06-26T11:16:01.546Z] 11:16:01     INFO - 
[task 2023-06-26T11:16:01.546Z] 11:16:01     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
[task 2023-06-26T11:16:01.547Z] 11:16:01     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
[task 2023-06-26T11:16:01.547Z] 11:16:01     INFO -    0 |TOTAL                                 |       47     4720| 3320036       30|
[task 2023-06-26T11:16:01.547Z] 11:16:01     INFO -  319 |EarlyHintPreloader                    |      352     3520|      10       10|
[task 2023-06-26T11:16:01.548Z] 11:16:01     INFO -  946 |ParentChannelListener                 |       96      960|     148       10|
[task 2023-06-26T11:16:01.548Z] 11:16:01     INFO - 1139 |ServiceWorkerInterceptController      |       24      240|     152       10|
[task 2023-06-26T11:16:01.550Z] 11:16:01     INFO - 
[task 2023-06-26T11:16:01.551Z] 11:16:01     INFO - nsTraceRefcnt::DumpStatistics: 2060 entries
[task 2023-06-26T11:16:01.551Z] 11:16:01     INFO - TEST-INFO | leakcheck | default leaked 10 EarlyHintPreloader
[task 2023-06-26T11:16:01.551Z] 11:16:01     INFO - TEST-INFO | leakcheck | default leaked 10 ParentChannelListener
[task 2023-06-26T11:16:01.551Z] 11:16:01     INFO - TEST-INFO | leakcheck | default leaked 10 ServiceWorkerInterceptController
[task 2023-06-26T11:16:01.552Z] 11:16:01     INFO - TEST-UNEXPECTED-FAIL | leakcheck | default 4720 bytes leaked (EarlyHintPreloader, ParentChannelListener, ServiceWorkerInterceptController)
[task 2023-06-26T11:16:01.552Z] 11:16:01     INFO - 
[task 2023-06-26T11:16:01.552Z] 11:16:01     INFO - leakcheck | Processing leak log file /var/folders/_s/31zcqkls21n2x5vcfxygc3hc000014/T/tmpbq_ll4f_/runtests_leaks_2255_tab_pid2354.log
[task 2023-06-26T11:16:01.553Z] 11:16:01     INFO - TEST-PASS | leakcheck | tab no leaks detected!

:zqianem, since you are the author of the regressor, bug 1798319, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(zqianem)

Set release status flags based on info from the regressing bug 1798319

Currently investigating this and will try to find a fix. Seems to be caused by a leftover reference to the EarlyHintPreloader created on this line when a combination of security flags and a cross-origin URL cause the preload to fail.

Previously, this caused a much larger leak before these three lines were moved up from the end of the function (so that they are always executed) in bug 1798319.

Flags: needinfo?(zqianem)
Blocks: earlyhints
Whiteboard: [necko-triaged]
Assignee: nobody → zqianem
Status: NEW → ASSIGNED
Duplicate of this bug: 1841260
Attachment #9341842 - Attachment description: Bug 1840356 - Fix ParentChannelListener leak r=manuel → Bug 1840356 - Fix EarlyHintPreloader leak r=manuel
Pushed by mbucher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/afef83606185 Fix EarlyHintPreloader leak r=manuel,necko-reviewers,kershaw
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

Set release status flags based on info from the regressing bug 1798319

The patch landed in nightly and beta is affected.
:zqianem, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(zqianem)
Flags: needinfo?(zqianem)

Hmm, I don't seem to have permission to set status-firefox116 to wontfix. Since EarlyHints in general is behind a flag, this probably doesn't need an uplift.

:kershaw, could you verify this reasoning and set the status if it makes sense? Thanks.

Flags: needinfo?(kershaw)

(In reply to zqianem from comment #11)

Hmm, I don't seem to have permission to set status-firefox116 to wontfix. Since EarlyHints in general is behind a flag, this probably doesn't need an uplift.

:kershaw, could you verify this reasoning and set the status if it makes sense? Thanks.

I'm happy to do this.
Thanks for your contribution!

Flags: needinfo?(kershaw)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: